[PAY 8/13] Request Money / Split Money Greater than or equal to 100,000,000 InDefinite Loading

[Santhosh-Sellavel]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create a new Request Money / Split
2. Enter Amount 100,000,000

Expected Result:

Case 1: If there is an upper Request limit, the user should be notified with an error message.
Case 2: No upper limit means the request should have been sent successfully.

Actual Result:

Indefinite loading

Request Money:

Screen.Recording.2021-07-17.at.8.22.30.PM.mov

Split:

Workaround:

Request amount less than 100,000,000. Even 99,999,999 works.

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Proposal

Need inputs from the Expensify team, this might be a back-end issue if there is no upper limit.

But I propose proper error handling should be done for situations like this. If a request fails based on request type we need to show appropriate messages to the user.

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @bfitzexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[MelvinBot]

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[thienlnam]

In the video you put in the description, it looks like we're actually getting a response back of invalid amount so it seems like this is handled in the back-end but just needs some front-end handling for when we get that error message

[thienlnam]

Luckily, my friends only owe me 99 million instead of 100 million

[Santhosh-Sellavel]

In the video you put in the description, it looks like we're actually getting a response back of invalid amount so it seems like this is handled in the back-end but just needs some front-end handling for when we get that error message

If I request in Rupees ₹100,000,000, Request fails.

But If request in pound £10,000,000, Request success.

Now User Owes more than ₹1,000,000,000.

100 Million rupees is invalid if I ask in rupees.
But I can ask 1 billion rupees if asked in £ pound.

@thienlnam

[thienlnam]

Interesting, are the responses the same on all the failed transactions?

[Santhosh-Sellavel]

@thienlnam Following are responses for failed transactions
Request Money :
{"jsonCode":405,"message":"405 invalid amount","requestID":"-------SOMEID-------"}

Split Bill:
{"jsonCode":404,"message":"404 Splits amount does not equal total amount","requestID":"-------SOMEID-----"}

[thienlnam]

Thanks @Santhosh-Sellavel, I think the most straightforward solution here is to catch those errors and show some kind of error message / cancel the transaction so the user doesn't sit on an infinite spinner