[QBO] [$250] Workspace settings – “Members must tag all spend” is enabled when all tags are disabled

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.68-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4524619
Email or phone of affected tester (no customers): applausetester+jp_e_category@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in as Collect WS Admin
3. Go to WS settings
4. Disable all categories and open Settings
5. Verify that “Members must categorize all spend” is locked
6. Disable all tags and open Settings
7. Verify that “Members must tag all spend” is enabled.

Expected Result:

Set up as required is locked when all tags and categories are disabled.

Actual Result:

Inconsistency between tags and categories settings. “Members must tag all spend” is enabled when all tags are disabled, but in categories setting “Members must categorize all spend” is locked when all categories are disabled.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6466258_1714458601941.Members_must_tag_all_spend.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01074744206851fea7
• Upwork Job ID: 1787964144555667456
• Last Price Increase: 2024-06-05

Issue Owner

Current Issue Owner: @rushatgabhane

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Changes in “Members must tag all spend” and “Members must categorise all spend”.

What is the root cause of that problem?

New change based on this comment.

In WorkspaceCategoriesSettingsPage, ToggleSettingOptionRow is used which has the disabled condition which also checks !hasEnabledOptions.

App/src/pages/workspace/categories/WorkspaceCategoriesSettingsPage.tsx

Lines 45 to 55 in e0c12a5

	<ToggleSettingOptionRow
	title={translate('workspace.categories.requiresCategory')}
	subtitle={isConnectedToAccounting ? `${translate('workspace.categories.needCategoryForExportToIntegration')} ${translate('workspace.accounting.qbo')}` : ''}
	isActive={policy?.requiresCategory ?? false}
	onToggle={updateWorkspaceRequiresCategory}
	pendingAction={policy?.pendingFields?.requiresCategory}
	disabled={!policy?.areCategoriesEnabled || !hasEnabledOptions || isConnectedToAccounting}
	wrapperStyle={[styles.mt2, styles.mh4]}
	errors={policy?.errorFields?.requiresCategory ?? undefined}
	onCloseError={() => Policy.clearPolicyErrorField(policy?.id ?? '', 'requiresCategory')}
	/>

Below is the code in WorkspaceTagsSettingsPage

App/src/pages/workspace/tags/WorkspaceTagsSettingsPage.tsx

Lines 63 to 68 in e0c12a5

	<Text style={[styles.textNormal, styles.colorMuted]}>{translate('workspace.tags.requiresTag')}</Text>
	<Switch
	isOn={policy?.requiresTag ?? false}
	accessibilityLabel={translate('workspace.tags.requiresTag')}
	onToggle={updateWorkspaceRequiresTag}
	/>

What changes do you think we should make in order to solve the problem?

Update isActive condition in WorkspaceCategoriesSettingsPage:

isActive={(policy?.requiresCategory ?? false) || isConnectedToAccounting}

disabled condition:

disabled={!policy?.areCategoriesEnabled || isConnectedToAccounting}

Instead of this, add the below block to use ToggleSettingOptionRow:

<View style={styles.flexGrow1}>
    <ToggleSettingOptionRow
        title={translate('workspace.tags.requiresTag')}
        isActive={policy?.requiresTag ?? false}
        accessibilityLabel={translate('workspace.tags.requiresTag')}
        onToggle={updateWorkspaceRequiresTag}
        pendingAction={policy?.pendingFields?.requiresTag}
        disabled={!policy?.areTagsEnabled}
        wrapperStyle={[styles.mt2, styles.mh4, styles.mb4]}
        errors={policy?.errorFields?.requiresTag ?? undefined}
        onCloseError={() => Policy.clearPolicyErrorField(policy?.id ?? '', 'requiresTag')}
    />
    <OfflineWithFeedback
        errors={policyTags?.[policyTagName]?.errors}
        pendingAction={policyTags?.[policyTagName]?.pendingAction}
        errorRowStyles={styles.mh5}
    >
        <MenuItemWithTopDescription
            title={policyTagName}
            description={translate(`workspace.tags.customTagName`)}
            onPress={() => Navigation.navigate(ROUTES.WORKSPACE_EDIT_TAGS.getRoute(route.params.policyID))}
            shouldShowRightIcon
        />
    </OfflineWithFeedback>
</View>

If we want to have a check on whethere at least one tag is enabled, then we can defined hasEnabledOptions like this:

const hasEnabledOptions = OptionsListUtils.hasEnabledOptions(PolicyUtils.getTagLists(policyTags)?.[0]?.tags ?? {});

And then pass it to disabled:

disabled={!policy?.areTagsEnabled || !hasEnabledOptions}

Similarly, if we want, this logic can be kept in categories settings also (it is already available there).

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Members must tag all spend” is enabled when all tags are disabled"

What is the root cause of that problem?

We don't disable the tag switch if there are no enabled options:

App/src/pages/workspace/tags/WorkspaceTagsSettingsPage.tsx

Lines 64 to 68 in e0c12a5

	<Switch
	isOn={policy?.requiresTag ?? false}
	accessibilityLabel={translate('workspace.tags.requiresTag')}
	onToggle={updateWorkspaceRequiresTag}
	/>

What changes do you think we should make in order to solve the problem?

We will add a check for enabled options here:

<Switch
    ...
    disabled={!policy?.areTagsEnabled || !hasEnabledOptions}
/>

[ShridharGoel]

Proposal

Updated

[melvin-bot]

@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@johncschuster Still overdue 6 days?! Let's take care of this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01074744206851fea7