[HOLD for payment 2024-05-22] [$250] Categories - Unable to go to other tabs after enabling " must categorize all spend" offline

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.68-0
Reproducible in staging?: y
Reproducible in production?: y
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go offline.
3. Go to Account settings > Workspaces.
4. Create a new workspace.
5. Go to Categories.
6. Click Settings.
7. Toggle on "Members must categorize all spend".
8. Close the RHP.
9. Navigate to other tabs.

Expected Result:

User should be able to navigate to other tabs after toggling on "Members must categorize all spend" offline.

Actual Result:

User is blocked from clicking on other tabs after toggling on "Members must categorize all spend" offline.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6466535_1714480419141.20240430_202756.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014991e62b8f3dcfbf
• Upwork Job ID: 1785348526516846592
• Last Price Increase: 2024-04-30
• Automatic offers:
• ikevin127 | Reviewer | 0
• Nodebrute | Contributor | 0

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[kbecciv]

@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[joekaufmanexpensify]

It doesn't only happen when you're offline. If you create a new workspace while online and enable this feature, it precludes accessing tabs in the workspace editor. Definitely a bug.

2024-04-30_12-39-00.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014991e62b8f3dcfbf

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Categories - Unable to go to other tabs after enabling " must categorize all spend" offline

What is the root cause of that problem?

Policy.errors will always be true instead we should check if it's an empty object

App/src/pages/workspace/WorkspaceInitialPage.tsx

Line 87 in 421581d

const hasPolicyCreationError = !!(policy?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD && policy.errors);

Enabling categories will make both of the above conditions true, which will result in all options being disabled.

App/src/pages/workspace/WorkspaceInitialPage.tsx

Line 357 in 421581d

disabled={hasPolicyCreationError || isExecuting}

What changes do you think we should make in order to solve the problem?

Instead of policy.error we should check for !isEmptyObject(policy.errors)
const hasPolicyCreationError = !!(policy?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD && !isEmptyObject(policy.errors));

App/src/pages/workspace/WorkspaceInitialPage.tsx

Line 87 in 421581d

const hasPolicyCreationError = !!(policy?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD && policy.errors);

Warning

I don't think we should use errors: null. If the policy had previous errors, enabling categories will reset all errors to null.

What alternative solutions did you explore? (Optional)