[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] Android - Scan - Pay elsewhere greyed on submitting expense with currency other than local

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.69
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4534392
Issue reported by: Applause - Internal Team

Action Performed:

Pre-condition: Workspace set in local currency and submission frequency set to manual

1. Launch app
2. Open Workspace chat
3. Create an expense with local currency
4. Tap submit and pay elsewhere
5. Note paid without any issue
6. Create an expense with currency other than local currency
7. Tap submit
8. Note pay elsewhere button greyed out
9. After tapping greyed out pay elsewhere button few times user able to pay

Expected Result:

In workspace, expense created with currency other than local currency when submitted, greyed out pay elsewhere button must not be displayed

Actual Result:

In workspace, expense created with currency other than local currency when submitted, greyed out pay elsewhere button displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Record_2024-05-01-22-36-10_4f9154176b47c00da84e32064abf1c48.mp4

Bug6468291_1714591468528.ws.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0198922fe1d95a1791
• Upwork Job ID: 1786776812730265600
• Last Price Increase: 2024-06-01

Issue Owner

Current Issue Owner: @eVoloshchak / @Christinadobrzyn

Issue Owner

Current Issue Owner: @bfitzexpensify / @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0198922fe1d95a1791

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[shreykul]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The pay elsewhere button is shown as greyed out or disabled when the user selects any other currency instead of the local currency when trying to pay a user.

What is the root cause of that problem?

const canAllowSettlement = ReportUtils.hasUpdatedTotal(moneyRequestReport, policy);

In the above code, there is a condition written in the function "hasUpdatedTotal" which checks if the local currency matches the selected currency if they don't match then the SettlementButton is shown as disabled.

App/src/libs/ReportUtils.ts

Line 6091 in 90b67a5

function hasUpdatedTotal(report: OnyxEntry<Report>, policy: OnyxEntry<Policy>): boolean {

What changes do you think we should make to solve the problem?

As the condition prevents the user from trying to pay before the currency is converted, the condition cannot be removed, instead of removing the condition, we can show the settlement button in a loading state when the currency is being converted and disable the settlement button if the user is offline.