[HOLD for payment 2024-06-20] [$125] [Invoice Rooms] Remove the option to allow users to update `Who can post` in invoice rooms

[danielrvidal]

Right now users can update who can post in invoice rooms from All members to Admins only. We do not restrict this to admins only ever in invoice rooms so we should not make it an option to change. We still do want to display the field Who can post but just make it so it says All members and remove the ability to change it.

For reference, we also just updated the invoice room settings to remove the Room name and Visibility altogether. Those will not be present at all.

Please let me know if there are any other questions. Assigning this a low clean up as I don't think it is super urgent.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014a363c4047d94da6
• Upwork Job ID: 1790255428707074048
• Last Price Increase: 2024-05-14
• Automatic offers:
• neonbhai | Contributor | 0

Issue Owner

Current Issue Owner: @jliexpensify

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove the option to allow users to update Who can post in invoice rooms

What is the root cause of that problem?

Feature Request

What changes do you think we should make in order to solve the problem?

We will update the shouldAllowWriteCapabilityEditing here to also account for !isInvoiceRoom(report)

App/src/libs/ReportUtils.ts

Lines 5720 to 5722 in 729c9ac

	function canEditWriteCapability(report: OnyxEntry<Report>, policy: OnyxEntry<Policy>): boolean {
	return PolicyUtils.isPolicyAdmin(policy) && !isAdminRoom(report) && !isArchivedRoom(report) && !isThread(report);
	}

Alternatively

We may add the check here:

App/src/pages/settings/Report/ReportSettingsPage.tsx

Line 109 in 729c9ac

(shouldAllowWriteCapabilityEditing ? (

Or here:

App/src/pages/settings/Report/ReportSettingsPage.tsx

Line 46 in 729c9ac

const shouldAllowWriteCapabilityEditing = useMemo(() => ReportUtils.canEditWriteCapability(report, linkedWorkspace), [report, linkedWorkspace]);

Result

This works perfectly

Screen.Recording.2024-05-02.at.11.18.59.AM.mov

[dragnoir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove the option to allow users to update Who can post in invoice rooms

What is the root cause of that problem?

New task

What changes do you think we should make in order to solve the problem?

on this part

App/src/pages/settings/Report/ReportSettingsPage.tsx

Lines 108 to 131 in 729c9ac

	{shouldShowWriteCapability &&
	(shouldAllowWriteCapabilityEditing ? (
	<MenuItemWithTopDescription
	shouldShowRightIcon
	title={writeCapabilityText}
	description={translate('writeCapabilityPage.label')}
	onPress={() => Navigation.navigate(ROUTES.REPORT_SETTINGS_WRITE_CAPABILITY.getRoute(reportID))}
	/>
	) : (
	<View style={[styles.ph5, styles.pv3]}>
	<Text
	style={[styles.textLabelSupporting, styles.lh16, styles.mb1]}
	numberOfLines={1}
	>
	{translate('writeCapabilityPage.label')}
	</Text>
	<Text
	numberOfLines={1}
	style={[styles.optionAlternateText, styles.pre]}
	>
	{writeCapabilityText}
	</Text>
	</View>
	))}

if shouldAllowWriteCapabilityEditing is true, we display a MenuItemWithTopDescription, else we display simple text

But MenuItemWithTopDescription can serve as a non intereactive component.

We need to only keep MenuItemWithTopDescription:

{shouldShowWriteCapability &&
-   (shouldAllowWriteCapabilityEditing ? (
                            <MenuItemWithTopDescription
+                              shouldShowRightIcon={shouldAllowWriteCapabilityEditing}
+                              interactive={shouldAllowWriteCapabilityEditing}
-                              title={writeCapabilityText}
+                              title={translate(`writeCapabilityPage.writeCapability.all`)}
                                description={translate('writeCapabilityPage.label')}
                                onPress={() => Navigation.navigate(ROUTES.REPORT_SETTINGS_WRITE_CAPABILITY.getRoute(reportID))}
                            />
-                       ) : (
-                           <View style={[styles.ph5, styles.pv3]}>
-                               <Text
-                                  style={[styles.textLabelSupporting, styles.lh16, styles.mb1]}
-                                 numberOfLines={1}
-                            >
-                               {translate('writeCapabilityPage.label')}
-                          </Text>
-                         <Text
-                            numberOfLines={1}
-                           style={[styles.optionAlternateText, styles.pre]}
-                      >
-                         {writeCapabilityText}
-                    </Text>
-               </View>
-          ))}

Add !isInvoiceRoom(report) to canEditWriteCapability so this will support also the access to WriteCapabilityPage

POC video:

20240502_160136.mp4

[melvin-bot]

Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

10 days overdue. Is anyone even seeing these? Hello?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014a363c4047d94da6

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)