[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Chat - Unable to navigate to LHN, back button loops between WS details & main chat page

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.70-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+1088ck@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL: Applause-Internal team
Issue reported by: Applause-Internal team

Action Performed:

1. Navigate to staging.new.expensify.com or ND app
2. Go to any Workspace chat page
3. Tap + icon >> select Assign task or Submit expense >> Complete the flow
4. Select the created task or expense to go report page
5. Tap on "From" link in header to go back to chat page
6. Tap on header to go to WS details page
7. Tap on back button (User redirected to main chat page)
8. Tap on back button (User again taken back to details page)
9. Repeat steps 7 & 8

Expected Result:

Unable should redirected to LHN, on tapping back button in main chat page

Actual Result:

Unable to navigate to LHN, back button loops between WS details & main chat page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6468992_1714664353275.RPReplay_Final1714664285.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0110f0cb9e34f0e6c4
• Upwork Job ID: 1787970200405659648
• Last Price Increase: 2024-05-14
• Automatic offers:
• rayane-djouah | Reviewer | 0
• bernhardoj | Contributor | 0

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The back button loops if we open the report detail page after visiting a linked message of a report.

What is the root cause of that problem?

If we open the detail page from a report, shouldNavigateToTopMostReport will be true.

App/src/pages/ReportDetailsPage.tsx

Lines 269 to 270 in 7483d10

	onBackButtonPress={Navigation.goBack}
	shouldNavigateToTopMostReport={!(route.params && 'backTo' in route.params)}

shouldNavigateToTopMostReport will navigate to the topmost report ID.

App/src/components/HeaderWithBackButton/index.tsx

Lines 154 to 157 in 7483d10

	if (shouldNavigateToTopMostReport && topmostReportId) {
	Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(topmostReportId));
	} else {
	onBackButtonPress();

But the navigation type will be changed to PUSH because the params are different. The topmost report has reportID and reportActionID in the params (linked message), but we navigate to a report without reportActionID.

App/src/libs/Navigation/linkTo.ts

Lines 166 to 179 in 7483d10

	} else if (action.payload.name === NAVIGATORS.CENTRAL_PANE_NAVIGATOR && (isTargetScreenDifferentThanCurrent || areParamsDifferent)) {
	// We need to push a tab if the tab doesn't match the central pane route that we are going to push.
	const topmostBottomTabRoute = getTopmostBottomTabRoute(rootState);
	const matchingBottomTabRoute = getMatchingBottomTabRouteForState(stateFromPath, policyID);
	const isNewPolicyID =
	(topmostBottomTabRoute?.params as Record<string, string | undefined>)?.policyID !== (matchingBottomTabRoute?.params as Record<string, string | undefined>)?.policyID;
	if (topmostBottomTabRoute && (topmostBottomTabRoute.name !== matchingBottomTabRoute.name || isNewPolicyID)) {
	root.dispatch({
	type: CONST.NAVIGATION.ACTION_TYPE.PUSH,
	payload: matchingBottomTabRoute,
	});
	}
	action.type = CONST.NAVIGATION.ACTION_TYPE.PUSH;

If we update the logic to only compares the reportID, this issue won't happen anymore, but it will remove the reportActionID from the param, so the message won't be linked anymore.

What changes do you think we should make in order to solve the problem?

To solve the issue correctly, we just need to remove shouldNavigateToTopMostReport from the details page.

if we want the user to see the report screen when going back after refresh, then it should be handled in this issue

[melvin-bot]

@johncschuster Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0110f0cb9e34f0e6c4

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)