[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] [Guided Setup Stage 2] "Meet your specialist" setup task not using proper Guide's calendar link

[francoisl]

Version Number: N/A (v1.4.70-0)
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): Any new account
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @francoisl
Slack conversation:

Action Performed:

1. Create a new account
2. During the onboarding flow, pick the option "manage my team's expenses"
3. After completing the onboarding modal steps, open the task "Meet your setup specialist"
4. Look at the "schedule a call" link

Expected Result:
The link should point to the assigned guide's calendly link.

As discussed in this thread, we need to remove the guide link from the message if not present at the time of flow completion.

If the guide link is present in NewDot in time, no changes to the current flow.

If not, the message will omit the link and as the task is created in the backend, we need to recreate the message correctly with the link. This is the internal task in this case

Actual Result:

The link points to the fallback new.expensify.com value, despite having a value in Onyx

App/src/libs/actions/Report.ts

Line 3055 in c5a1f96

guideCalendarLink: guideCalendarLink ?? CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL,

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Issue Owner

Current Issue Owner: @Christinadobrzyn

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018008e7f232e1b5aa
• Upwork Job ID: 1788750602254168064
• Last Price Increase: 2024-05-10

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01082698f3bc5a219c

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[trjExpensify]

No idea why Melvin did that, will look at it here.

I've tried to restore Franc's wonderful words in the OP!

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Meet your specialist" setup task not using proper Guide's calendar link

What is the root cause of that problem?

guideCalendarLink will be undefined if the task's data got created before we get the guidesCalendarLink from backend.

App/src/libs/actions/Report.ts

Lines 167 to 173 in 7636b01

	let guideCalendarLink: string | undefined;
	Onyx.connect({
	key: ONYXKEYS.ACCOUNT,
	callback: (value) => {
	guideCalendarLink = value?.guideCalendarLink ?? undefined;
	},
	});

App/src/libs/actions/Report.ts

Lines 3051 to 3057 in 7636b01

	const taskDescription =
	typeof task.description === 'function'
	? task.description({
	adminsRoomLink: `${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL}${ROUTES.REPORT_WITH_ID.getRoute(adminsChatReportID ?? '')}`,
	guideCalendarLink: guideCalendarLink ?? CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL,
	})
	: task.description;

This will take the link only if it is already available, else new.expensify.com will be used.

What changes do you think we should make in order to solve the problem?

If guideCalendarLink is undefined while creating the task description, we should add it as an empty string while creating the optimistic data.

Then, backend can check if the link for "schedule a call" is empty in the description. If yes, then backend will add the guide's calendar link and send it in the task description.

App side change will be to change the fallback to '':

typeof task.description === 'function'
                ? task.description({
                      adminsRoomLink: `${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL}${ROUTES.REPORT_WITH_ID.getRoute(adminsChatReportID ?? '')}`,
                      guideCalendarLink: guideCalendarLink ?? '',
                  })
                : task.description;

[Christinadobrzyn]

@rayane-djouah can you check out the above proposal when you have a moment? TY!