[HOLD for payment 2024-06-20] [Search v1] Opening transactions on search page can lead to not found page

[luacmartins]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

1. Open the search page, Profile > Troubleshoot > New Search Page
2. Click on a transaction
3. Verify that you see a not found page

Note: this seems to only happen for older transactions that don't have a transaction thread created since the value for transactionThreadReportID is 0.

Expected Result:

We should create the transaction thread and let users open the transaction

Actual Result:

Not found page is shown

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

https://github.com/Expensify/App/assets/22219519/ed64830c-ca4d-4ba7-b95e-c066fe5d6084

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b78bbfebf5ef557c
• Upwork Job ID: 1786400627125800960
• Last Price Increase: 2024-05-03

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b78bbfebf5ef557c

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Santhosh-Sellavel (Internal)

[grgia]

What we chatted about before:
Create a command - OpenTransactionThread (maybe OpenSearchItemPreview if we later need to add support for previewing reports? )
That calls auth.transaction.createTransactionThread if it doesn't already exist

App/src/components/Search.tsx

Line 68 in b475b28

openReport(item.transactionThreadReportID);

Use the loading indicator on the page