[HOLD for payment 2024-07-10] [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Pay someone flow doesn’t include a reportAction to distinguish the payment method used (Expensify or elsewhere)

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.70-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714729020479179

Action Performed:

Prerequisite: Pay someone with either Expensify or elsewhere option

1. Login as a user who got paid
2. Open the DM and observe the preview for money received
3. Click to open the payment details and observe

Expected Result:

Method of payment displayed in both DM and details page (Expensify or elsewhere)

Actual Result:

Only xyz paid displayed and method of payment not displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014f39f2dacd55f2a4
• Upwork Job ID: 1787959016608243712
• Last Price Increase: 2024-05-21
• Automatic offers:
• ahmedGaber93 | Reviewer | 102528931
• nkdengineer | Contributor | 102528935

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[jainilparikh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Payment type is not mentioned in the details page.

What is the root cause of that problem?

We do not have a field for payment type. We only have fields for 'amount', 'comment', 'merchant', 'date', 'category' and 'tag'.

What changes do you think we should make in order to solve the problem?

Add a new field similar to the one below for 'PaymentType' info:

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 373 to 386 in 951c7b3

	{canUseViolations && <ViolationMessages violations={getViolationsForField('receipt')} />}
	<OfflineWithFeedback pendingAction={getPendingFieldAction('amount')}>
	<MenuItemWithTopDescription
	title={formattedTransactionAmount ? formattedTransactionAmount.toString() : ''}
	shouldShowTitleIcon={isSettled}
	titleIcon={Expensicons.Checkmark}
	description={amountDescription}
	titleStyle={styles.textHeadlineH2}
	interactive={canEditAmount}
	shouldShowRightIcon={canEditAmount}
	onPress={() => Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_AMOUNT.getRoute(CONST.IOU.ACTION.EDIT, iouType, transaction?.transactionID ?? '', report.reportID))}
	brickRoadIndicator={getErrorForField('amount') ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined}
	error={getErrorForField('amount')}
	/>

PaymentType info is available in ParentReportAction array that's passed to this component.

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 90 in 951c7b3

parentReportActions,

What alternative solutions did you explore? (Optional)

[melvin-bot]

@sakluger Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014f39f2dacd55f2a4

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)