[HOLD FOR #40565][$250] Chat - Mention is not displayed in compose box when editing a message

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.71-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4546634
Issue reported by: Applause - Internal Team

Action Performed:

1. Log in to New Expensify
2. Navigate to any chat
3. Send a message with user mention
4. Edit the message
5. If the mention is displayed cancel the edit and repeat step 4

Expected Result:

Mentions should be displayed when editing messages

Actual Result:

Mention is not displayed in edit compose box

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6473962_1715099426584.2024-05-07_18-28-32.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013489c9a79accb0a7
• Upwork Job ID: 1788009417512591360
• Last Price Increase: 2024-05-08

Issue Owner

Current Issue Owner: @hungvu193

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[jliexpensify]

Ah weird, yes - can repro this.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013489c9a79accb0a7

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Mention is not displayed in edit compose box

What is the root cause of that problem?

We return an empty string when there is no match for the account in the map here

https://github.com/Expensify/expensify-common/blob/182ef7f5824617b8893abaedee9855b5d66faf95/lib/ExpensiMark.js#L488

and we are not passing any extras here

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Line 241 in e0b6a06

Report.saveReportActionDraft(reportID, reportAction, parser.htmlToMarkdown(getActionHtml(reportAction)));

so extras take the default {} here

https://github.com/Expensify/expensify-common/blob/182ef7f5824617b8893abaedee9855b5d66faf95/lib/ExpensiMark.js#L865

and accountToNameMap becomes undefined here

https://github.com/Expensify/expensify-common/blob/182ef7f5824617b8893abaedee9855b5d66faf95/lib/ExpensiMark.js#L486-L488
and the mention is replaced by ''

What changes do you think we should make in order to solve the problem?

We should create an accountIdToName map and pass it in extras to parser.htmlToMarkdown at all places.

What alternative solutions did you explore? (Optional)