[HOLD for payment 2024-06-11] [Xero][QBO] [Wave Collect] Add error message in case of sync failure

[lakchote]

Problem

Right now, if an error occurs during sync, we do not display it to the user.

Solution

Display an error to the user to indicate sync wasn't successful, to avoid confusion.

You should display as error text, Couldn't connect to {integrationName}.

Implement hasSynchronizationError() by doing so.

[SzymczakJ]

Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue!

[trjExpensify]

Interesting yeah, this was mocked up in QBO, did it not get implemented? CC: @hayata-suenaga

[SzymczakJ]

I don't see anything like this in codebase, so probably we forgot about this 🤷

[lakchote]

Side note

Thanks to @SzymczakJ for notifying me of this.

Actually I've created the issue for Xero, it was closed by mistake by the PR that fixed the disconnect button not working for Xero.

Maybe my issue's title was too vague: Handle errors in the connections
I should have written down: Handle sync errors for the accounting integrations
& also double checked the related issue.

[trjExpensify]

Ah cool, so we're just going to use this issue now?

[hayata-suenaga]

Interesting yeah, this was mocked up in QBO, did it not get implemented? CC: @hayata-suenaga

Yes seems like we missed it in this PR and this PR
Thank you Lucien for realizing this and handling this 🙇

[lakchote]

Ah cool, so we're just going to use this issue now?

I think yes to avoid confusion, what do you think? We could change the other's issue title/body to reflect it was to fix the disconnect option. Waiting on your answer on this, and I'll update if necessary.

Thank you Lucien for realizing this and handling this 🙇

To be fair, it's @yuwenmemon's message on Slack that got me the lead 😄

[trjExpensify]

I think yes to avoid confusion, what do you think? We could change the other's issue title/body to reflect it was to fix the disconnect option. Waiting on your answer on this, and I'll update if necessary.

Nah, all good. Let's use this one!