[Awaiting checklist] [$250] IOU - App crashed after deleting IOU and relaunching app

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.75-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Open the app and log in
2. Open any 1:1 chat
3. Tap + > Submit expense
4. Open the created IOU and delete it
5. Navigate back to LHN
6. Open the same chat again
7. Kill the app and open it again

Expected Result:

The app opens and LHN is displayed

Actual Result:

The app crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6489440_1716471167435.video_2024-05-23_09-31-16.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0160e20b7c9a05d3c9
• Upwork Job ID: 1793688592596738048
• Last Price Increase: 2024-05-30
• Automatic offers:
• ahmedGaber93 | Reviewer | 102740724
• abzokhattab | Contributor | 102740725

Issue Owner

Current Issue Owner: @ahmedGaber93

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashed after deleting IOU and relaunching app

What is the root cause of that problem?

after removing the IOU, the returned report action of the deleted IOU here is null so the null value cannot be deconstructed thus the app crashes:

App/src/hooks/useReportIDs.tsx

Lines 77 to 94 in 06f4dab

	const reportActionsSelector = (reportActions: OnyxEntry<OnyxTypes.ReportActions>): ReportActionsSelector =>
	(reportActions &&
	Object.values(reportActions).map((reportAction) => {
	const {reportActionID, actionName, errors = [], originalMessage} = reportAction;
	const decision = reportAction.message?.[0]?.moderationDecision?.decision;
	return {
	reportActionID,
	actionName,
	errors,
	message: [
	{
	moderationDecision: {decision},
	},
	] as Message[],
	originalMessage,
	};
	})) as ReportActionsSelector;

What changes do you think we should make in order to solve the problem?

we need to filter null report actions first. so before the .map we need to add .filter(Boolean)

        Object.values(reportActions) .filter(Boolean).map((reportAction) => {

and do this in other locations if needed inside the ReportUtils.ts file

POC

Screen.Recording.2024-05-23.at.6.42.45.PM.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0160e20b7c9a05d3c9

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[aksh1t]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After deleting an IOU and navigating back to the chat screen, the app crashes on restart.

What is the root cause of that problem?

When deleting an IOU, we set its report action id to null here:

App/src/libs/actions/IOU.ts

Lines 5320 to 5326 in 8375abe

	if (shouldDeleteIOUReport) {
	successData.push({
	onyxMethod: Onyx.METHOD.SET,
	key: `${ONYXKEYS.COLLECTION.REPORT}${iouReport?.reportID}`,
	value: null,
	});
	}

This then causes a null check crash here because we are trying to read a null value:

App/src/hooks/useReportIDs.tsx

Line 80 in 8375abe

const {reportActionID, actionName, errors = [], originalMessage} = reportAction;

What changes do you think we should make in order to solve the problem?

We can check for null values and filter them out before we process them. Something like this:

Object.values(reportActions).filter(action => action != null).map((reportAction) => {

What alternative solutions did you explore? (Optional)

Another thing I explored was to try removing the report id completely from Onyx when deleting, but it seems that's not how Onyx is meant to work. null ing out values is how they are supposed to be deleted, so a null check is the right way to fix this.

[ahmedGaber93]

Reviewing tomorrow