[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] Categorizing - New workspace button does not create new WS if previous WS is selected first

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.75-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• There is a workspace with different categories than the default categories (can be obtained by disabling a few or adding new ones, for the purpose of differentiating).

1. Go to staging.new.expensify.com
2. Go to FAB > Track expense
3. Track a manual expense
4. In 1:1 DM, click Categorize it from the whisper
5. Click on the workspace from precondition
6. Select any category
7. Click back button twice to return to workspace selection page
8. Click New workspace button

Expected Result:

The list of default categories will appear because the workspace is new

Actual Result:

Categories from the previously selected workspace appear instead of new set of default categories from the new workspace.
After selecting a category, the workspace chat in the confirmation page is the previous workspace instead of the new workspace when New workspace button is selected

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6489718_1716487907960.bandicam_2024-05-24_02-05-42-656.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018fccdf6165f3ba87
• Upwork Job ID: 1798110907708002304
• Last Price Increase: 2024-06-04
• Automatic offers:
• tienifr | Contributor | 102686152

Issue Owner

Current Issue Owner: @kevinksullivan

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@kevinksullivan FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Categorizing - New workspace button does not create new WS if previous WS is selected first

What is the root cause of that problem?

We don't create a workspace if we have a participant selected.

App/src/pages/iou/request/step/IOURequestStepParticipants.tsx

Lines 118 to 121 in 791058a

	if ((isCategorizing || isShareAction) && numberOfParticipants.current === 0) {
	ReportUtils.createDraftWorkspaceAndNavigateToConfirmationScreen(transactionID, action);
	return;
	}

What changes do you think we should make in order to solve the problem?

We can pass CONST.IOU.ACTION.CREATE or add something to track if the create workspace button is pressed and then pass the string from here:

App/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

Lines 326 to 334 in 791058a

	{isCategorizeOrShareAction && (
	<Button
	success
	text={translate('workspace.new.newWorkspace')}
	onPress={() => onFinish()}
	pressOnEnter
	large
	/>
	)}

And we can check for the string instead of numberOfParticipants.current === 0. or we can check for both with || check.

App/src/pages/iou/request/step/IOURequestStepParticipants.tsx

Lines 118 to 121 in 791058a

	if ((isCategorizing || isShareAction) && numberOfParticipants.current === 0) {
	ReportUtils.createDraftWorkspaceAndNavigateToConfirmationScreen(transactionID, action);
	return;
	}

What alternative solutions did you explore? (Optional)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Categories from the previously selected workspace appear instead of new set of default categories from the new workspace.
After selecting a category, the workspace chat in the confirmation page is the previous workspace instead of the new workspace when New workspace button is selected

What is the root cause of that problem?

• When we are in IOURequestStepParticipants page, then select any existed workspace (for example workspace A), the participants is set to [A] in here and numberOfParticipants is set to 1 in here.

• Then the category picker page is opened.

• Then, go back to the IOURequestStepParticipants page. In here, numberOfParticipants is still 1. That leads to when we click on New workspace button, this condition is not true because numberOfParticipants.current is 1. So clicking on New workspace is considered as clicking on A workspace.

What changes do you think we should make in order to solve the problem?

• We need to reset the participants and numberOfParticipants if we focused on the IOURequestStepParticipants page and action === CONST.IOU.ACTION.CATEGORIZE. For example, we can add bellow logic to this:

const isFocused = useIsFocused();
    useEffect(()=>{
        const isCategorizing = action === CONST.IOU.ACTION.CATEGORIZE;
        const isShareAction = action === CONST.IOU.ACTION.SHARE;
        if(isFocused && (isCategorizing || isShareAction)){
            IOU.setMoneyRequestParticipants(transactionID, [])
            numberOfParticipants.current = 0
        }
    }, [isFocused, action, transactionID])

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

@kevinksullivan 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@kevinksullivan 10 days overdue. I'm getting more depressed than Marvin.

[kevinksullivan]

I believe this is a VSB bug, because it's about the track flow