[HOLD for Payment 2024-06-21] Flag message - "Only visible to you" disappears after flagging the whisper, and then reappears

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.75-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• User is invited to a workspace

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Right click on the welcome whisper message
4. Click Flag as offensive
5. Select Spam

Expected Result:

"Only visible to you" will remain above the welcome message after flagging the whisper

Actual Result:

Only visible to you" disappears after flagging the whisper, and then reappears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6489769_1716490934768.bandicam_2024-05-24_02-58-34-780.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@NikkiWines FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[NikkiWines]

Given the testing steps, seems like it might be tied to #41622. @dangrous could you confirm?

[dangrous]

Hm yeah looks like it might be a missed piece from that implementation. Maybe isWhisper is no longer returning true when it's flagged? Not sure why though - I'm happy to look into it, though, since it's my code, or we can push external?

[NikkiWines]

If you want to look, I'd be happy to review your PR 🤝

[dangrous]

Cool, I can self-assign this now and take a look when I'm back in on Tuesday... is that too late? I don't think this needs to be a deploy blocker, imo.