Tax - Tax rate and amount are blank when tax rate is selected when splitting expense

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.76-0
Reproducible in staging?: Y
Reproducible in production?: N
**If this was caught during regression testing, add the test name, ID and link from TestRail:**N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #40240

Action Performed:

Precondition:

• Workspace is tax-enabled

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Submit a split scan expense
4. While the receipt is scanning, click on the split preview
5. Click Amount
6. Enter amount and save it
7. Click Tax rate
8. Select a tax rate and save it
9. Click Split expense
10. Go to the transaction thread

Expected Result:

The selected tax rate and computed tax amount will be displayed in transaction thread

Actual Result:

Tax rate and tax amount rows are empty in transaction thread when tax rate is selected when splitting expense

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6493099_1716827762906.20240528_003148.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@roryabraham FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-split

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tax rate and amount still be blank when updating tax rate when splitting expense

What is the root cause of that problem?

When adjusting the tax rate and amount, we invoke the completeSplitBill function, but we don't pass taxRate and taxAmount to this function.

App/src/libs/actions/IOU.ts

Line 4800 in 95d328f

const parameters: CompleteSplitBillParams = {

What changes do you think we should make in order to solve the problem?

We need to update the optimisticData and params within the completeSplitBill function to incorporate taxRate and taxAmount. Moreover, it appears that the startSplitBill function faces a similar issue, so we should address it as well.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[bondydaa]

the revert #42670 has been deployed, please retest and confirm this is no longer reproducible.

[kavimuru]

This bug is not reproducible because of #40755

20240528_095847.mp4

[puneetlath]

Ah great. Closing.