[HOLD for payment 2024-07-26] [$250] BUG: Failed distance request isn't cleaned up properly

[neil-marcellini]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: main
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): applausetester+kh300501@applause.expensifail.com
Logs: 88c4715bea025f6f-SIN
Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/400806#top
Issue reported by: @neil-marcellini
Slack conversation:

Action Performed:

1. Log into NewDot
2. Create a workspace if needed
3. Go offline in the Network tab of dev tools, or using the force offline switch
4. Create a distance request on that workspace
5. Log into the same account on OldDot (expensify.com.dev)
6. Go to your group workspaces
7. Delete the workspace
8. Go back to NewDot, and go online
9. Verify the request fails to create
10. Click on the request
11. Verify there is an error message that says "Unexpected error submitting this expense. Please try again later. The workspace is no longer accessible. Please try again on a different workspace."
12. Click the X to dismiss the error

Expected Result:

The failed request should disappear completely after the error is dismissed. The transaction report should be deleted and the request should be removed from the workspace chat. Everything needs to be cleaned up. The user can get navigated back the the archived workspace chat, or something like that.

We should also probably improve the error message, and have it translated vs only in English from the backend. Requesting copy now.

Actual Result:

The transaction report remains with a RBR indicator, and the request is also still visible in the archived workspace chat

Workaround:

Sign out and back in to clear all optimistic/failure data

Platforms:

Which of our officially supported platforms is this issue occurring on?
All

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

335710534-aaa87b61-51d5-420e-bad6-1cb41c493858.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b6ac9eda43aba0be
• Upwork Job ID: 1796631286961946624
• Last Price Increase: 2024-06-07
• Automatic offers:
• dominictb | Contributor | 102768394

Issue Owner

Current Issue Owner: @sobitneupane

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b6ac9eda43aba0be

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

Triggered auto assignment to @CherylWalsh (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

[neil-marcellini]

Hi @CherylWalsh, could we please have your expertise in coming up with a helpful error message for the user to see in this case. It's likely to happen if they create a distance request while offline, and then before they go back online an admin deletes the policy, or removes them from it.