[HOLD for payment 2024-07-24] [$250] Public room - User is able to leave public room when user is not logged in

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.81-3
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Log out if logged in.
3. Navigate to public room link.
4. Click on the public room chat header.
5. Click Leave.

Expected Result:

Login modal will open.

Actual Result:

User is able to leave the public room, and the public room reappears.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6508355_1718037560053.bandicam_2024-06-11_00-34-48-344.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012198a597d90e1a9d
• Upwork Job ID: 1800460939784883037
• Last Price Increase: 2024-06-11
• Automatic offers:
• situchan | Reviewer | 102730618
• codinggeek2023 | Contributor | 102730619
• truph01 | Contributor | 102895803

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #vip-vsb

[devguest07]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Users can leave a public room without being logged in.

What is the root cause of that problem?

The leave button is displayed regardless of whether the user is anonymous or not.

App/src/pages/ReportDetailsPage.tsx

Line 207 in 60530f6

if (isGroupChat || (isChatRoom && ReportUtils.canLeaveChat(report, policy ?? null))) {

What changes do you think we should make in order to solve the problem?

We need to add a condition to check for anonymous users before displaying the leave button, similar to other parts of the application.

https://github.com/Expensify/App/blob/60530f643b30f30510914ed28e2a90ed5d37184a/src/pages/home/report/ReportFooter.tsx#L91C12-L91C27

Add !isAnonymousUser to the condition controlling the display of the leave menu item.

App/src/pages/ReportDetailsPage.tsx

Line 207 in 60530f6

if (isGroupChat || (isChatRoom && ReportUtils.canLeaveChat(report, policy ?? null))) {

What alternative solutions did you explore?

[eucool]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User is able to leave public room when user is not logged in

What is the root cause of that problem?

We have set isAnonymousAction to true which allows the user to proceed with exiting the room but that won't happen as the user is not logged in and hence we get redirected to concierge.

App/src/pages/ReportDetailsPage.tsx

Lines 207 to 212 in 60530f6

	if (isGroupChat || (isChatRoom && ReportUtils.canLeaveChat(report, policy ?? null))) {
	items.push({
	key: CONST.REPORT_DETAILS_MENU_ITEM.LEAVE_ROOM,
	translationKey: 'common.leave',
	icon: Expensicons.Exit,
	isAnonymousAction: true,

What changes do you think we should make in order to solve the problem?

The expected results is to redirect the user to login page, so we need to set isAnonymousAction to false.

Result Video

Screen.Recording.2024-06-11.at.1.11.52.AM.mov

[Tony-MK]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Error page when navigating to Workspace Join link after leaving the workspace

What is the root cause of that problem?

The root cause of the problem is that in the ReportDetailsPage we use the ReportUtils.canLeaveChat function instead of the ReportUtils.canLeaveRoom function.

App/src/pages/ReportDetailsPage.tsx

Line 207 in 65db650

if (isGroupChat || (isChatRoom && ReportUtils.canLeaveChat(report, policy ?? null))) {

What changes do you think we should make in order to solve the problem?

Change the code snippet above and use the ReportUtils.canLeaveRoom function as shown below.

if (isGroupChat || (isChatRoom && ReportUtils.canLeaveRoom(report, isPolicyEmployee))) 

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012198a597d90e1a9d