[Simple AA in NewDot] No option to leave workspace as non-owner

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.81-8
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @Beamanator
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1718092341741619

Action Performed:

1. As User A, create policy in NewDot
2. Invite two other users. Promote User B to workspace admin, and leave User C as a regular user
3. Log in as User B
4. Open workspace members page & try to leave the workspace
5. Log in as User C
6. Open workspace members page & try to leave the workspace
   Expected Result: Both User B and User C should be able to leave the workspace

Expected Result:

There should be a way for a workspace non-owner to leave a workspace.

Actual Result:

There's no way for either of the workspace non-owners to leave the workspace.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-06-11.at.10.50.01.AM.mov

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• There should be a way for a non-owner workspace admin to leave a workspace.

What is the root cause of that problem?

• If the current user is admin, we always display button:
  

  App/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

  Lines 186 to 194 in 8ed1e04

  	<Button
  	text={translate('workspace.people.removeMemberButtonTitle')}
  	onPress={askForConfirmationToRemove}
  	medium
  	isDisabled={isSelectedMemberOwner || isSelectedMemberCurrentUser}
  	icon={Expensicons.RemoveMembers}
  	iconStyles={StyleUtils.getTransformScaleStyle(0.8)}
  	style={styles.mv5}
  	/>

• And the above button is disabled because of the condition:
  

  App/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

  Line 190 in 8ed1e04

  isDisabled={isSelectedMemberOwner || isSelectedMemberCurrentUser}

What changes do you think we should make in order to solve the problem?

• We can display the Button having the title "Leave" and when pressing on it, call Policy.leaveWorkspace(policyID ?? ''). This button is only displayed if current user is admin and not a owner. To do that, we can update logic:

• App/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

  Lines 185 to 195 in 8ed1e04

  	) : (
  	<Button
  	text={translate('workspace.people.removeMemberButtonTitle')}
  	onPress={askForConfirmationToRemove}
  	medium
  	isDisabled={isSelectedMemberOwner || isSelectedMemberCurrentUser}
  	icon={Expensicons.RemoveMembers}
  	iconStyles={StyleUtils.getTransformScaleStyle(0.8)}
  	style={styles.mv5}
  	/>
  	)}

  
  to:

) : isCurrentUserAdmin && !isCurrentUserOwner ? (
                            <Button
                                text={'Leave'}
                                onPress={() => Policy.leaveWorkspace(policyID)}
                                medium
                                icon={Expensicons.RemoveMembers}
                                iconStyles={StyleUtils.getTransformScaleStyle(0.8)}
                                style={styles.mv5}
                            />
                        ) : (
                            <Button
                                text={translate('workspace.people.removeMemberButtonTitle')}
                                onPress={askForConfirmationToRemove}
                                medium
                                isDisabled={isSelectedMemberOwner || isSelectedMemberCurrentUser}
                                icon={Expensicons.RemoveMembers}
                                iconStyles={StyleUtils.getTransformScaleStyle(0.8)}
                                style={styles.mv5}
                            />
                        )}

• We should add "Leave" option to this logic:
  

  App/src/pages/workspace/WorkspacesListPage.tsx

  Line 152 in 8d11d0b

  const getMenuItem = useCallback(

  
  if current user is admin but not owner as well.
• Then BE need to fix the LeavePolicy API so that non owner admin can leave workspace.

What alternative solutions did you explore? (Optional)

• With the member of the workspace who is not admin or owner, we also need to display "Leave" option which allows them to leave workspace as well because we already displayed "Leave" option in WorkspaceListPage if user is not admin and owner:
  

  App/src/pages/workspace/WorkspacesListPage.tsx

  Lines 173 to 179 in 8d11d0b

  	if (!(isAdmin || isOwner)) {
  	threeDotsMenuItems.push({
  	icon: Expensicons.ChatBubbles,
  	text: translate('common.leave'),
  	onSelected: Session.checkIfActionIsAllowed(() => Policy.leaveWorkspace(item.policyID ?? '')),
  	});
  	}

[devguest07]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Admin is not able to remove himself from a workspace.

What is the root cause of that problem?

On the WorkspaceMemberDetailsPage, the "Remove from workspace" button is disabled when the selected member is the same user.

App/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

Line 190 in 3523ca6

isDisabled={isSelectedMemberOwner || isSelectedMemberCurrentUser}

What changes do you think we should make in order to solve the problem?

As requested in this issue, we should not disable the "Remove from workspace" button for the user.

We can remove the isSelectedMemberCurrentUser check.

App/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

Line 190 in 3523ca6

isDisabled={isSelectedMemberOwner || isSelectedMemberCurrentUser}

We can modify the isSelectedMemberCurrentUser check to ensure the user is an admin. If the selected member is the same user and he is an admin isCurrentUserAdmin, we should not disable the "Remove from workspace" button.

What alternative solutions did you explore?

[Beamanator]

FYI we haven't added the Help Wanted label yet b/c we're still designing out exactly how we want this to work, so I wouldn't recommend adding proposals yet 😅

[johncschuster]

Thanks for the update, @Beamanator. In that case, should this be Daily?

[johncschuster]

@Beamanator, did the discussion land on this?

[Beamanator]

Fair, maybe weekly is better 😅 I have been OOO yesterday and most of last friday so i have some stuff to catch up on, but the latest should be in the linked slack thread! I can try to look at this today soonish as well :D