[$250] Send invoice - Invoice thread name can renamed when created offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.82-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go offline.
3. Go FAB > Send invoice.
4. Send invoice to a user.
5. Go to transaction thread.
6. Click report header > Settings.
7. Click Room name.
8. Go online.
9. Repeat Step 6 and 7.

Expected Result:

Invoice thread name cannot be renamed when created offline, because it can't be renamed online

Actual Result:

Invoice thread name can renamed when created offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6510719_1718191819509.20240612_192647.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0189569ee60be7065e
• Upwork Job ID: 1803295776701776707
• Last Price Increase: 2024-06-26
• Automatic offers:
• shubham1206agra | Reviewer | 102975673
• cretadn22 | Contributor | 102975676

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Tony-MK]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Send invoice - Invoice thread name can renamed when created offline

What is the root cause of that problem?

The problem is that the MenuItem in ReportSettingsPage is always enabled when offline for every type of report.

App/src/pages/settings/Report/ReportSettingsPage.tsx

Lines 78 to 86 in 79e619a

	{shouldDisableRename ? (
	<View style={[styles.ph5, styles.pv3]}>
	<Text
	style={[styles.textLabelSupporting, styles.lh16, styles.mb1]}
	numberOfLines={1}
	>
	{roomNameLabel}
	</Text>
	<DisplayNames

This is because the ReportUtils.shouldDisableRename function always does not check for invoice reports.

App/src/pages/settings/Report/ReportSettingsPage.tsx

Line 34 in 79e619a

const shouldDisableRename = useMemo(() => ReportUtils.shouldDisableRename(report, linkedWorkspace), [report, linkedWorkspace]);

What changes do you think we should make in order to solve the problem?

We should edit using the shouldDisableRename boolean but we need to edit the ReportUtils.shouldDisableRename function to include invoice reports.

App/src/libs/ReportUtils.ts

Lines 6103 to 6104 in 79e619a

	if (isDefaultRoom(report) || isArchivedRoom(report) || isThread(report) || isMoneyRequestReport(report) || isPolicyExpenseChat(report)) {
	return true;

So, let's use the ReportUtils.isInvoiceReport function in the condition above.

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Send invoice - Invoice thread name can renamed when created offline

What is the root cause of that problem?

When operating online, the shouldDisableRename function will indicate true because the invoice report is a thread. However, in offline mode, since the invoice report lacks a 'parentReportActionID', the isThread function returns false, consequently causing shouldDisableRename to also return false.

What changes do you think we should make in order to solve the problem?

When creating optimistic data for invoice report, we should include parentReportActionID

Currently, we're generating the invoice report prior to creating the optimistic report action

App/src/libs/actions/IOU.ts

Lines 1758 to 1759 in 79e619a

	// STEP 2: Create a new optimistic invoice report.
	const optimisticInvoiceReport = ReportUtils.buildOptimisticInvoiceReport(chatReport.reportID, senderWorkspaceID, receiverAccountID, receiver.displayName ?? '', amount, currency);

App/src/libs/actions/IOU.ts

Lines 1805 to 1806 in 79e619a

	// STEP 5: Build optimistic reportActions.
	const [optimisticCreatedActionForChat, optimisticCreatedActionForIOUReport, iouAction, optimisticTransactionThread, optimisticCreatedActionForTransactionThread] =

My suggestion is that we generate a random ID, similar to what we did when creating the optimistic report action

App/src/libs/ReportUtils.ts

Line 4624 in c82dafd

reportActionID: NumberUtils.rand64(),

Then we will use this reportActionID for both optimistic invoiceReport and optimistic reportAction

What alternative solutions did you explore? (Optional)

[Tony-MK]

Proposal

Updated

[melvin-bot]

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0189569ee60be7065e