[HOLD for payment 2024-07-10] [$250] Track expense - "Delete expense" option appears for paid tracked expense

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.82-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Submit an expense
4. Track an expense
5. Pay elsewhere the expense report
6. Go to transaction thread of tracked expense
7. Click 3-dot menu

Expected Result:

"Delete expense" option will not appear for paid tracked expense

Actual Result:

"Delete expense" option appears for paid tracked expense

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6511017_1718207360141.20240612_234631.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bb7f209695580cf5
• Upwork Job ID: 1802802568068548628
• Last Price Increase: 2024-06-17
• Automatic offers:
• eh2077 | Reviewer | 102806652
• bernhardoj | Contributor | 102806654

Issue Owner

Current Issue Owner: @kevinksullivan

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@kevinksullivan FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Delete expense" option appears for paid tracked expense

What is the root cause of that problem?

App/src/components/MoneyReportHeader.tsx

Lines 81 to 82 in 9376991

	const canDeleteRequest =
	isActionOwner && (ReportUtils.canAddOrDeleteTransactions(moneyRequestReport) || ReportUtils.isTrackExpenseReport(transactionThreadReport)) && !isDeletedParentAction;

We manually add isTrackExpenseReport condition to display the delete option in paid track expense

What changes do you think we should make in order to solve the problem?

Before we need to add isTrackExpenseReport condition because canAddOrDeleteTransactions doesn't cover track expense case. At present, let's remove isTrackExpenseReport condition because canAddOrDeleteTransactions also cover track expense case.

Consider to make the same fix to MoneyRequestHeader

What alternative solutions did you explore? (Optional)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Delete expense option is shown for paid track expense.

What is the root cause of that problem?

The delete option is always shown for track expense report.

App/src/components/MoneyRequestHeader.tsx

Line 103 in a451de4

const canDeleteRequest = isActionOwner && (ReportUtils.canAddOrDeleteTransactions(moneyRequestReport) || ReportUtils.isTrackExpenseReport(report)) && !isDeletedParentAction;

This is useful for self DM track expense report because the moneyRequestReport is the parent report which is self DM,

App/src/components/MoneyRequestHeader.tsx

Line 63 in a451de4

const moneyRequestReport = parentReport;

so canAddOrDeleteTransactions returns false for selfDM track expense. In a normal money request or workspace track expense, we have IOU/expense report and then the transaction thread.

chat report -> money request report -> transaction thread

But in self DM track expense, we only have the track expense report/transaction thread

self DM -> track expense report

What changes do you think we should make in order to solve the problem?

We need to also check whether the track expense is a self DM track or not.

const isSelfDMTrack = ReportUtils.isTrackExpenseReport(report) && ReportUtils.isSelfDM(parentReport);
const moneyRequestReport = !isSelfDMTrack ? parentReport : undefined; <- optional, just so it's more predictable
const canDeleteRequest = ... && (ReportUtils.canAddOrDeleteTransactions(moneyRequestReport) || isSelfDMTrack) && ...

We also have the same condition in MoneyReportHeader that is shown in the money request report, but self DM track doesn't have money request report, so we can remove it (remove ReportUtils.isTrackExpenseReport(report))

App/src/components/MoneyReportHeader.tsx

Lines 81 to 82 in a451de4

	const canDeleteRequest =
	isActionOwner && (ReportUtils.canAddOrDeleteTransactions(moneyRequestReport) || ReportUtils.isTrackExpenseReport(transactionThreadReport)) && !isDeletedParentAction;

What alternative solutions did you explore? (Optional)

In canAddOrDeleteTransactions, returns true if it's a self DM.

App/src/libs/ReportUtils.ts

Lines 1506 to 1509 in a451de4

	function canAddOrDeleteTransactions(moneyRequestReport: OnyxEntry<Report>): boolean {
	if (!isMoneyRequestReport(moneyRequestReport)) {
	return false;
	}

if (isSelfDM(moneyRequestReport)) return true

But I don't like this one because canAddOrDeleteTransactions is expected to work with a money request report.

Instead, we can add a new optional param to canAddOrDeleteTransactions called transactionReport and if transactionReport is a self DM track, then returns true.

[melvin-bot]

@kevinksullivan Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bb7f209695580cf5