[HOLD for payment 2024-07-10] [$250] Category - "Category no longer valid" shows up briefly after changing amount

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.83-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• "Members must categorize all expenses" in Categories is enabled.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense with category.
4. Go to transaction thread.
5. Click Amount.
6. Change amount and save it.

Expected Result:

There will be no violation under Category after changing amount because Category is already selected.

Actual Result:

"Category no longer valid" shows up briefly after changing amount when the selected category is valid.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6513040_1718362398903.bandicam_2024-06-14_18-44-14-234.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017067ba3b0cc2101a
• Upwork Job ID: 1803116505548368516
• Last Price Increase: 2024-06-18
• Automatic offers:
• allgandalf | Contributor | 102815523
• truph01 | Contributor | 102828819

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Category no longer valid" shows up briefly after changing amount

What is the root cause of that problem?

We are not passing policyCategories here

App/src/pages/iou/request/step/IOURequestStepAmount.tsx

Line 305 in f0b6355

IOU.updateMoneyRequestAmountAndCurrency({transactionID, transactionThreadReportID: reportID, currency, amount: newAmount, taxAmount, policy, taxCode});

so in here policyCategories will be null

App/src/libs/actions/IOU.ts

Line 5240 in 07b6b24

data = getUpdateMoneyRequestParams(transactionID, transactionThreadReportID, transactionChanges, policy ?? null, policyTagList ?? null, policyCategories ?? null, true);

So that's why when here we check for policyCategories?.[categoryKey]?.enabled it will be undefined

App/src/libs/Violations/ViolationsUtils.ts

Line 190 in 07b6b24

const isCategoryInPolicy = categoryKey ? policyCategories?.[categoryKey]?.enabled : false;

What changes do you think we should make in order to solve the problem?

We should pass policyCategories here

App/src/pages/iou/request/step/IOURequestStepAmount.tsx

Line 305 in f0b6355

IOU.updateMoneyRequestAmountAndCurrency({transactionID, transactionThreadReportID: reportID, currency, amount: newAmount, taxAmount, policy, taxCode});

Additionally we can also pass policyTags

We can do something like this

        IOU.updateMoneyRequestAmountAndCurrency({transactionID, transactionThreadReportID: reportID, currency, amount: newAmount, taxAmount, policy,policyTags,policyCategories, taxCode});

Note: This is just pseudocode.

   policyCategories: {
        key: ({report}) => `${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${report ? report.policyID : '-1'}`,
    },
    policyTags: {
        key: ({report}) => `${ONYXKEYS.COLLECTION.POLICY_TAGS}${report ? report.policyID : '-1'}`,
    },

We can also fix other instances of this to ensure we are passing all the data.

What alternative solutions did you explore? (Optional)

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[OfstadC]

I'm not able to reproduce on staging

I've tried different currencies, having a tag field, no tag field. Clicking in to edit the expense a few different ways - but I never see the category error
Most recent attempt:
https://github.com/Expensify/App/assets/11722379/90d898f4-5194-489b-bf8b-c3b11e0f5a27

[Nodebrute]

Hey @OfstadC, It's easily reproducible on staging. Try it with this precondition.
Precondition: "Members must categorize all expenses" in Categories is enabled.

[OfstadC]

Let me give it another shot! 😃

[OfstadC]

I missed the "...must categorize all expenses" detail 🤦‍♀️ . It is very reproducible 😅