[$250] Expensify personal - Not here page opens when opening Expensify profile from group member list

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.84-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Start chat
3. Create a group chat with "Expensify"
4. Click on the group chat header > Members
5. Click Expensify
6. Click Profile

Expected Result:

Expensify profile will open without issue

Actual Result:

Not here page shows up when opening Expensify profile from group chat member list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6515676_1718636209822.expppensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f91896edfd02fabc
• Upwork Job ID: 1820597582663880018
• Last Price Increase: 2024-08-19

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Not found page shows when opening the expensify account from group member list.

What is the root cause of that problem?

The profile page will show the not found page if the account is in the restricted account list and the expensify account is in that list (and the only one).

App/src/pages/ProfilePage.tsx

Line 144 in b335423

const shouldShowBlockingView = (!isValidAccountID && !isLoading) || CONST.RESTRICTED_ACCOUNT_IDS.includes(accountID);

App/src/CONST.ts

Lines 2073 to 2076 in b335423

	// Account IDs that profile view is prohibited
	get RESTRICTED_ACCOUNT_IDS() {
	return [this.ACCOUNT_ID.NOTIFICATIONS];
	},

But previously, we can't create a group with an expensify account at all, but this PR now allows the expensify account to be shown in the new chat/search list result.

What changes do you think we should make in order to solve the problem?

We can hide the Profile button if the account is the restricted account.

App/src/pages/ReportParticipantDetailsPage.tsx

Lines 138 to 143 in b335423

	<MenuItem
	title={translate('common.profile')}
	icon={Expensicons.Info}
	onPress={navigateToProfile}
	shouldShowRightIcon
	/>

Or if we want to allow the user to see the expensify profile, then we need to remove the restricted account check here.

App/src/pages/ProfilePage.tsx

Line 144 in b335423

const shouldShowBlockingView = (!isValidAccountID && !isLoading) || CONST.RESTRICTED_ACCOUNT_IDS.includes(accountID);

Or again, we can prevent the expensify account from being added to the group.

App/src/pages/NewChatPage.tsx

Lines 209 to 213 in 9ec57c0

	const itemRightSideComponent = useCallback(
	(item: ListItem & OptionsListUtils.Option) => {
	if (item.isSelfDM) {
	return null;
	}

if (item.isSelfDM || CONST.RESTRICTED_ACCOUNT_IDS.includes(item.accountID)) {
    return null;
}

notice there is another expensify account and we can add it to the restricted list if needed

[alexpensify]

I'll review this one soon.

[alexpensify]

No update yet

[alexpensify]

Still on my testing radar

[alexpensify]

Other GHs and customer tasks have been a higher priority, I'll get to this one soon.