[$125] Profile - The character limit has not been increased to 100 characters

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.84_2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4632338
Email or phone of affected tester (no customers): albertodege+2024@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Prerequisite: The user is logged in to the website.

1. Navigate to the Legal name page
2. Enter a a long name (>100 characters) and save and save
3. Verify there's an error about character limit exceeded

Expected Result:

The user should not be able to submit a legal name that is longer 100 characters

Actual Result:

The character limit has not been increased to 100 characters

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01125f9cbfc0be0653
• Upwork Job ID: 1803119001279122354
• Last Price Increase: 2024-06-18

Issue Owner

Current Issue Owner: @hoangzinh

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@sakluger FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[devguest07]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Character limit should be 100

What is the root cause of that problem?

character limit is set to 40

App/src/pages/settings/Profile/PersonalDetails/LegalNamePage.tsx

Line 69 in c4482aa

} else if (values.legalLastName.length > CONST.LEGAL_NAME.MAX_LENGTH) {

What changes do you think we should make in order to solve the problem?

Change the limit to 100

App/src/pages/settings/Profile/PersonalDetails/LegalNamePage.tsx

Line 69 in c4482aa

} else if (values.legalLastName.length > CONST.LEGAL_NAME.MAX_LENGTH) {

App/src/CONST.ts

Lines 166 to 168 in c4482aa

	LEGAL_NAME: {
	MAX_LENGTH: 40,
	},

[sakluger]

This is a very simple change so I'm going to set the price to $125.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01125f9cbfc0be0653

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[melvin-bot]

Upwork job price has been updated to $125