[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Send invoice - "Chat Report" appears in room mention list after sending invoice

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.85-4
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Type #.
4. Note that there is no Chat report in the mention list.
5. Go to FAB > Send invoice.
6. Send invoice to anyone under the same workspace.
7. Go to workspace chat.
8. Type #.
9. Select Chat Report from the list.

Expected Result:

If Chat Report is a valid room mention, selecting it from the list should result in highlighted #Chat Report in the composer.

Actual Result:

Selecting Chat Report from room mention list does not highlight the mention. # disappears.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

20240619_124104.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01327604e093a2db66
• Upwork Job ID: 1803444749926103230
• Last Price Increase: 2024-06-19
• Automatic offers:
• ahmedGaber93 | Reviewer | 102956284
• bernhardoj | Contributor | 102956286

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #vip-vsb

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A "Chat report" shown in the report mentions suggestions after sending an invoice.

What is the root cause of that problem?

A report will show in the suggestion if it passes the canReportBeMentionedWithinPolicy condition.

App/src/libs/ReportUtils.ts

Lines 6934 to 6940 in e0ff35b

	function canReportBeMentionedWithinPolicy(report: OnyxEntry<Report>, policyID: string): boolean {
	if (report?.policyID !== policyID) {
	return false;
	}
	return isChatRoom(report) && !isThread(report);
	}

An invoice room is considered a chat room.

App/src/libs/ReportUtils.ts

Lines 968 to 970 in e0ff35b

	function isChatRoom(report: OnyxEntry<Report>): boolean {
	return isUserCreatedPolicyRoom(report) || isDefaultRoom(report) || isInvoiceRoom(report);
	}

The invoice room has a Chat report as the name. Chat report is basically a default name for a report. If you see the invoice room header, the name isn't Chat room because there is another logic to get the invoice room name.

What changes do you think we should make in order to solve the problem?

I don't think we should include the invoice room as a mentionable room because it's not a room that follows a room name condition that starts with a #. So, I suggest ignoring the invoice room in canReportBeMentionedWithinPolicy.

return isChatRoom(report) && !isInvoiceRoom(report) && !isThread(report);

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01327604e093a2db66

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[ahmedGaber93]

@bernhardoj's proposal LGTM!

🎀 👀 🎀 C+ reviewed