[HOLD for payment 2024-07-10] [$250] Group – Long loading when leave the group as a last user and tap on back arrow

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v90.0-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4652183
Email or phone of affected tester (no customers): ponikarchuks+315324@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in
3. Create a group with another user
4. Send some messages
5. Click on the header
6. Remove all existing members from the group
7. Leave the group
8. When chat opens tap on the back arrow

Expected Result:

User leave the group successfully

Actual Result:

Long loading when leave the group as a last user and tap on the back arrow. Hmm... page appears some times

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6520323_1718960720670.leave_group.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018eb150a3cf89e4b1
• Upwork Job ID: 1805278589522616125
• Last Price Increase: 2024-06-24
• Automatic offers:
• s77rt | Reviewer | 102867389
• bernhardoj | Contributor | 102867392

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #vip-vsb

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A skeleton loader shows after leaving a group and press go back.

What is the root cause of that problem?

When we leave the group, it will navigate to the most recent report.

App/src/libs/actions/Report.ts

Lines 2574 to 2576 in 68374a5

	if (lastAccessedReportID) {
	const lastAccessedReportRoute = ROUTES.REPORT_WITH_ID.getRoute(lastAccessedReportID ?? '-1');
	Navigation.goBack(lastAccessedReportRoute);

What the goBack do in this case is, if the most recent report is found in the stack, we will pop all the screens up to that most recent report, otherwise, we replace the current screen.

App/src/libs/Navigation/Navigation.ts

Lines 236 to 246 in 68374a5

	// Allow CentralPane to use UP with fallback route if the path is not found in root navigator.
	if (isCentralPaneFocused && fallbackRoute && distanceFromPathInRootNavigator === -1) {
	navigate(fallbackRoute, CONST.NAVIGATION.TYPE.UP);
	return;
	}
	// Add possibility to go back more than one screen in root navigator if that screen is on the stack.
	if (isCentralPaneFocused && fallbackRoute && distanceFromPathInRootNavigator > 0) {
	navigationRef.current.dispatch(StackActions.pop(distanceFromPathInRootNavigator));
	return;
	}

In our case, the report/group details RHP page is replaced with the most recent report, so the group report page is still in the navigation stack. When we press back, the group report page is shown with a skeleton loader because we left the group.

This happens regardless whether we are the last user or not.

What changes do you think we should make in order to solve the problem?

When we want to leave from group, call Navigation.dismissModal first to make sure the details page is closed.

App/src/pages/ReportDetailsPage.tsx

Lines 118 to 125 in 68374a5

	const leaveChat = useCallback(() => {
	if (isChatRoom) {
	const isWorkspaceMemberLeavingWorkspaceRoom = (report.visibility === CONST.REPORT.VISIBILITY.RESTRICTED || isPolicyExpenseChat) && isPolicyEmployee;
	Report.leaveRoom(report.reportID, isWorkspaceMemberLeavingWorkspaceRoom);
	return;
	}
	Report.leaveGroupChat(report.reportID);
	}, [isChatRoom, isPolicyEmployee, isPolicyExpenseChat, report.reportID, report.visibility]);

App/src/pages/ReportDetailsPage.tsx

Lines 389 to 392 in 68374a5

	onConfirm={() => {
	setIsLastMemberLeavingGroupModalVisible(false);
	Report.leaveGroupChat(report.reportID);
	}}

[zanyrenney]

reviewed, added to VIP VSB.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018eb150a3cf89e4b1

[zanyrenney]

adding external.