[HOLD for payment 2024-07-24] [$250] Distance - Start and Stop labels do not change when dragging one over another

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.0.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4652117
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Launch New Expensify app.
2. Go to FAB > Submit expense > Distance.
3. Drag empty Stop row over empty Start row.
4. Note that the Stop label does not change to Start and Start label does not change to stop.
5. Tap on the Stop row.
6. Select a waypoint.
7. Now Stop and Start rows overlap with one another.

Expected Result:

In Step 4, Stop label will change to Start and Start label will change to stop.

Actual Result:

In Step 4, Stop label does not change to Start and Start label does not change to stop.
In Step 7, when selecting a waypoint, Stop and Start rows overlap with one another.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6520253_1718958048871.Screen_Recording_20240621_161639_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b23211c128469d40
• Upwork Job ID: 1805046118243790605
• Last Price Increase: 2024-06-24
• Automatic offers:
• hoangzinh | Contributor | 102892776
• Krishna2323 | Contributor | 102911936

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance - Start and Stop labels do not change when dragging one over another

What is the root cause of that problem?

The draggable list requires key for correctly render the items when dragged. When we create draft transaction, there is no key for empty waypoints and due to this the list isn't updated correctly.

App/src/libs/actions/IOU.ts

Lines 339 to 344 in 9817d3c

	// Add initial empty waypoints when starting a distance expense
	if (iouRequestType === CONST.IOU.REQUEST_TYPE.DISTANCE) {
	comment.waypoints = {
	waypoint0: {},
	waypoint1: {},
	};

What changes do you think we should make in order to solve the problem?

We need to make sure that we add keys for empty waypoints too, we can create a const for initial waypoints list.

        comment.waypoints = {
            waypoint0: {keyForList: 'start_waypoint'},
            waypoint1: {keyForList: 'stop_waypoint'},
        };

App/src/pages/iou/request/step/IOURequestStepDistance.tsx

Line 79 in 9817d3c

const waypoints = useMemo(() => optimisticWaypoints ?? transaction?.comment?.waypoints ?? {waypoint0: {}, waypoint1: {}}, [optimisticWaypoints, transaction]);

Note: We also need to modify the function which checks for duplicate waypoints.

    // Remove keyForList list property before using `isEmpty`.
    const nonEmptyWaypointsCount = useMemo(
        () =>
            Object.keys(waypoints).filter((key) => {
                const {keyForList, ...waypointWithoutKey} = waypoints[key];
                return !isEmpty(waypointWithoutKey);
            }).length,
        [waypoints],
    );

What alternative solutions did you explore? (Optional)

We can use math.random to generate random keys when keyForList or other field are not present, we can use isEmpty for that.

App/src/pages/iou/request/step/IOURequestStepDistance.tsx

Line 440 in 9817d3c

keyExtractor={(item) => (waypoints[item]?.keyForList ?? waypoints[item]?.address ?? '') + item}

Result

waypoint_drag_issue.mp4

[jliexpensify]

I can reproduce, but also have asked the team here if we want to lock down those points, so they can't be dragged.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b23211c128469d40

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[jliexpensify]

Ok we are good to look at proposals @abdulrahuman5196 , thanks!