Chat - messages sent while the conversation is loading in offline are not shown

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.1-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): dawitseife9@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Login to an account
2. Disable the internet connection in the device
3. Navigate to a chat with history that you have not opened
4. Notice that the chat opens and the loading animation is shown
5. Sent a message

Expected Result:

Message is shown with 50% opacity

Actual Result:

Sent Message is not shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6522973_1719236388340.loading_issue.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

@dangrous FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[dangrous]

Looks like #43970 (comment) - looking into it now. Not backend.

[dangrous]

it's something with the definition of shouldShowSkeleton; if I hardcode that to false there's other weird behavior but the messages show.

Specifically, if I remove the (reportActions.length < paginationSize && !doesCreatedActionExists && !!reportMetadata?.isLoadingInitialReportActions) || part, it also shows the pending message correctly - but the skeleton doesn't show UNTIL you send the pending message, so it's somewhere in that line.