[HOLD for payment 2024-09-17][$250] Web - Concierge - Concierge in unavailable workspace when create new account

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.2-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): gocemate+a444@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Login with a new Gmail account
3. Complete the onboarding modal requests
4. Take a look at the Concierge chat header

Expected Result:

There should be only Concierge label on Concierge chat header

Actual Result:

"Concierge in unavailable workspace" can be seen on the Concierge chat header after creating a new account

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013152861e0170f045
• Upwork Job ID: 1806787876528252448
• Last Price Increase: 2024-09-03
• Automatic offers:
• allgandalf | Reviewer | 103818556
• wildan-m | Contributor | 103818557

Issue Owner

Current Issue Owner: @cristipaval

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@sakluger FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013152861e0170f045

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

[jainilparikh]

Edited by proposal-police: This proposal was edited at 2024-08-15 07:29:48 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

'Unavailable workspace ' appears when a User attempts to login with a fresh Gmail account.

What is the root cause of that problem?

Within HeaderView.ts we invoke 1getPolicyName function to get the sub-heading. Note: We send true for returnEmptyIfNotFound flag.

https://github.com/Expensify/App/blob/main/src/pages/home/HeaderView.tsx#L113

Within the getPolicyName function, when there report has no policies (This happens when it's a new user), we don't respect the returnEmptyIfNotFound flag.

https://github.com/Expensify/App/blob/main/src/libs/ReportUtils.ts#L745

What changes do you think we should make in order to solve the problem

Replace

if ((!allPolicies || Object.keys(allPolicies).length === 0) && !report?.policyName) {
        return unavailableTranslation;
    }

With

if ((!allPolicies || Object.keys(allPolicies).length === 0) && !report?.policyName) {
        return noPilicyFound;
}

The noPolicyFound variable (link) take's care of respecting the returnEmptyIfNotFound flag.