[HOLD for payment 2024-07-17] [$250] IOS - Transfer owner - App returns to empty screen when swiping right on success screen

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.2-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• User is invited to a workspace
• User is also promoted to admin

1. Go to app
2. Go to workspace settings > Members
3. Tap on the owner
4. Tap Transfer owner
5. Proceed to success screen
6. Swipe right on the screen (iOS style)

Expected Result:

App will return to member profile page

Actual Result:

App returns to an empty Transfer owner screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6525504_1719422967878.RPReplay_Final1719422678.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01054e6abc7abcdf2c
• Upwork Job ID: 1806448714527773045
• Last Price Increase: 2024-06-27
• Automatic offers:
• c3024 | Reviewer | 102950095

Issue Owner

Current Issue Owner: @MitchExpensify / @MitchExpensify

Issue Owner

Current Issue Owner: @puneetlath / @MitchExpensify

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@MitchExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[layacat]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App returns to empty screen when swiping right on success screen

What is the root cause of that problem?

After we changed owner, we navigate user to screens based on the result screen in here:

App/src/pages/workspace/members/WorkspaceOwnerChangeWrapperPage.tsx

Lines 37 to 47 in 9d8e7fe

	if (!policy.errorFields && policy.isChangeOwnerFailed) {
	// there are some errors but not related to change owner flow - show an error page
	Navigation.navigate(ROUTES.WORKSPACE_OWNER_CHANGE_ERROR.getRoute(policyID, accountID));
	return;
	}
	if (!policy?.errorFields?.changeOwner && policy?.isChangeOwnerSuccessful) {
	// no errors - show a success page
	Navigation.navigate(ROUTES.WORKSPACE_OWNER_CHANGE_SUCCESS.getRoute(policyID, accountID));
	return;
	}

While we still kept WorkspaceOwnerChangeWrapperPage in the stack, error will be empty if we swipe back from Success or Error screen.

App/src/pages/workspace/members/WorkspaceOwnerChangeWrapperPage.tsx

Line 30 in 9d8e7fe

const error = route.params.error;

.

And now this function will return all empty texts:

App/src/libs/WorkspacesSettingsUtils.ts

Lines 280 to 285 in 9d8e7fe

	default:
	title = '';
	text = '';
	buttonText = '';
	break;
	}

That's the root cause.

What changes do you think we should make in order to solve the problem?

Add Navigation.goBack() right before we navigating user to success or error screen in here and here

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

📣 @layacat! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01054e6abc7abcdf2c

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)