[HOLD for payment 2024-07-24] [$125] Transfer owner - "Continue" button is missing bottom margin

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.4-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: #44712
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• User is invited to a workspace.
• User is also promoted to admin.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Members.
3. Click on the owner.
4. Click Transfer owner.

Expected Result:

"Continue" button on "Duplicate subscription alert" page will have bottom margin.

Actual Result:

"Continue" button on "Duplicate subscription alert" page does not have bottom margin.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6532565_1720050037604.20240704_073840.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01851c277cf7d0a07b
• Upwork Job ID: 1811060685379521358
• Last Price Increase: 2024-07-11

Issue Owner

Current Issue Owner: @miljakljajic

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Continue" button is missing bottom margin

What is the root cause of that problem?

In WorkspaceOwnerChangeCheck we are not adding bottom margin to the Button component

App/src/pages/workspace/members/WorkspaceOwnerChangeCheck.tsx

Lines 79 to 83 in 83eb7e6

	<Button
	success
	large
	onPress={confirm}
	text={displayTexts.buttonText}

What changes do you think we should make in order to solve the problem?

1. Wrap the Button in View component
2. Add styles.pb5 to the View component

<View style={styles.pb5}>
                <Button...

What alternative solutions did you explore? (Optional)

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Transfer owner - "Continue" button is missing bottom margin

What is the root cause of that problem?

Padding/Margin bottom isn't added when error !== CONST.POLICY.OWNERSHIP_ERRORS.NO_BILLING_CARD is true.

App/src/pages/workspace/members/WorkspaceOwnerChangeWrapperPage.tsx

Line 72 in 2784712

<View style={[styles.containerWithSpaceBetween, error !== CONST.POLICY.OWNERSHIP_ERRORS.NO_BILLING_CARD ? styles.ph5 : styles.ph0, styles.pb0]}>

What changes do you think we should make in order to solve the problem?

Add Padding/Margin bottom when error !== CONST.POLICY.OWNERSHIP_ERRORS.NO_BILLING_CARD is true just like we add horizontal padding.

What alternative solutions did you explore? (Optional)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Transfer owner - "Continue" button is missing bottom margin

What is the root cause of that problem?

App/src/pages/workspace/members/WorkspaceOwnerChangeCheck.tsx

Lines 79 to 84 in 74a6dbb

	<Button
	success
	large
	onPress={confirm}
	text={displayTexts.buttonText}
	/>

We don't add bottom margin to the button

What changes do you think we should make in order to solve the problem?

We implemented FixedFooter Component to align this bug on other pages

<FixedFooter style={[styles.mtAuto, styles.pt5]}>
                <Button
                    success
                    large
                    onPress={confirm}
                    text={displayTexts.buttonText}
                />
</FixedFooter>

What alternative solutions did you explore? (Optional)

[melvin-bot]

@miljakljajic Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01851c277cf7d0a07b