[$250] Chat-On adding spade symbol, link is changed to text.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.4
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Tap on a report
3. Enter govinda.com
4. Long tap message and select edit comment
5. Enter °•●●□■ along with link name and save it
6. Note link can be seen
7. Long tap message and select edit comment
8. Now include ♤ along with link name and save it
9. Note link is shown as text
10. Long tap message and select edit comment
11. Remove spade symbol and save it
12. Note now shown as link

Expected Result:

On adding spade symbol, link must not be changed to text.

Actual Result:

On adding spade symbol, link is changed to text.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6532762_1720075009162.az_recorder_20240704_083446_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a1dba0f8a6c08731
• Upwork Job ID: 1808902546673127823
• Last Price Increase: 2024-07-04
• Automatic offers:
• rayane-djouah | Reviewer | 103069056

Issue Owner

Current Issue Owner: @rayane-djouah

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #vip-vsb

[twisterdotcom]

Okay... this is super niche. I'm going to make it Monthly because this is super niche.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a1dba0f8a6c08731

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Adding spade symbol to the link text doesn't convert it to link.

What is the root cause of that problem?

The spade symbol is an emoji, while the others are not emoji.

Based on the link markdown replacement logic, we don't allow emojis to be inside the link text.
https://github.com/Expensify/expensify-common/blob/2610f15e7fb8d98d19b3841146c693df7be0a5c9/lib/ExpensiMark.ts#L249-L256

It's to fix this issue where the link underline partly behind the emoji character which doesn't look good, so we disable emoji inside link text.

What changes do you think we should make in order to solve the problem?

Allow the emoji back to be inside the link text by removing the emoji check condition here.

This is how it looks when an emoji is inside the link text.

GitHub also allows emoji to be inside link text

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On adding spade symbol, link is changed to text.

What is the root cause of that problem?

In https://github.com/Expensify/expensify-common/blob/2610f15e7fb8d98d19b3841146c693df7be0a5c9/lib/ExpensiMark.ts#L252, we don't match link text that has any emojis.

This was an oversight from this PR Expensify/expensify-common#536, we should not allow link text with only emojis because it will not look good (described in the issue description), but if emojis are with other texts, we should still allow it. That will be the behavior consistent with Slack.

What changes do you think we should make in order to solve the problem?

Put the method containsOnlyEmojis inside expensify-common (as a method of Str)

In https://github.com/Expensify/expensify-common/blob/2610f15e7fb8d98d19b3841146c693df7be0a5c9/lib/ExpensiMark.ts#L252, remove g1.match(Constants.CONST.REG_EXP.EMOJIS) and use containsOnlyEmojis to check if g1 contains only emojis.

What alternative solutions did you explore? (Optional)

In addition to that that check, we could check that length of g1 is 1, so if the link text contains only 1 emoji, it will not be matched as link text.