[HOLD for payment 2021-09-16] Desktop - Big empty space in message fields if copy/paste the Text from MAC Note.app

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue was found when executing the PR #4363

Action Performed:

1. Navigate to a conversation that has some messages.
2. Paste the Text from MAC note.app to the composer.

Expected Result:

Only entered message should be visible in compose field if copy/paste the Text from MAC Note.app

Actual Result:

Big empty space in message compose field if copy/past the Text from MAC Note.app

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Desktop App

Version Number:
v1.0.83-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5182815_empty.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[bondydaa]

I am OOO

[francoisl]

@parasharrajat - just checking, it looks like you were aware of this issue, correct? Was there a separate GH issue that was opened to track the bug where newlines are prepended to messages pasted into the message box?

[parasharrajat]

No, a new issue was not opened at that time. I was waiting for #4363 to merge as only after that, this behaviour is revealed.
So with an inspection, I come to know that the Mac Note app. usages   chars to show spaces which are also needed to be escaped and current _.unescape does not do that. I think we need a custom implementation as is not made to parse HTMLEntities and its usages do not seem sufficient any more.

About the main issue, let me quickly take a good peek at it. Only then I can tell what is causing this much space.

[roryabraham]

I think we should demote this from deploy blocker to regular-old 🐛