[HOLD for payment 2024-07-24] [$250] Review duplicates - "Unhold" option appears for expenses that are pending duplicate reviews

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.4-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit two expenses with the same amount and merchant.
4. Go to transaction thread of any expense.
5. After Review duplicates button appears, click on the report header.
6. Click Unhold.

Expected Result:

"Unhold" option should be appear for expenses that are pending review for duplicates.

Actual Result:

"Unhold" option appeara for expenses that are pending review for duplicates.
Clicking Unhold does not unhold the expense.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6533175_1720102978084.20240704_221038.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e9c4febbfea1864e
• Upwork Job ID: 1810654131699118867
• Last Price Increase: 2024-07-09
• Automatic offers:
• ahmedGaber93 | Reviewer | 103060862

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unhold option shows for duplicated expense.

What is the root cause of that problem?

Duplicated expense is considered a hold too.

App/src/libs/TransactionUtils.ts

Lines 678 to 684 in c5eafd3

	function isOnHold(transaction: OnyxEntry<Transaction>): boolean {
	if (!transaction) {
	return false;
	}
	return !!transaction.comment?.hold || isDuplicate(transaction.transactionID, true);
	}

And the unhold option will show if the expense is on hold. But it's not really a "hold", so doing an unhold request won't remove the duplicate violation.

What changes do you think we should make in order to solve the problem?

Don't allow unhold if it's hold because of duplicate expenses violation.

App/src/libs/ReportUtils.ts

Line 2832 in c5eafd3

const canUnholdRequest = !!(canHoldOrUnholdRequest && isOnHold && (isRequestHoldCreator || (!isRequestIOU && canModifyStatus))) && !!transaction?.reimbursable;

(isOnHold && !TransactionUtils.isDuplicate(transaction.transactionID, true))

What alternative solutions did you explore? (Optional)

Keep showing the unhold option, but when pressed, do the same action as "Review duplicates" button, that is open the review duplicates page,

[melvin-bot]

@zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick!

[zanyrenney]

changing to collect actually.