Edit workspace page gets automatically closed on Submit

[aman-atg]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to newDot
2. Go to Workspace page
3. Edit Workspace name
4. Save and it'll close itself automatically

Expected Result:

Shouldn't close itself and additionally we can show a feedback message instead
(it should behave like Edit Profile Page for consistency)

Actual Result:

expensifyBug-2021-08-07_12.16.56.mp4

bug2.mp4

Workaround:

Open the edit page again.

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @zanyrenney (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[aman-atg]

Proposal

• We can fix this by removing Navigation.dismissModal() from line 245

  App/src/libs/actions/Policy.js

  Lines 234 to 247 in 50828ab

  	function update(policyID, values) {
  	API.UpdatePolicy({policyID, value: JSON.stringify(values), lastModified: null})
  	.then((policyResponse) => {
  	if (policyResponse.jsonCode !== 200) {
  	// Show the user feedback
  	const errorMessage = translateLocal('workspace.editor.genericFailureMessage');
  	Growl.error(errorMessage, 5000);
  	return;
  	}
  	Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, values);
  	Navigation.dismissModal();
  	});
  	}

• Additionally, we can show a Growl here

[mananjadhav]

Possible duplicate of #4487 ?

[aman-atg]

That one is related to "Save" Button and this one is about the overall workflow, Right?

[mananjadhav]

For me, the sidebar closing is the expected behavior. Because once you've edited you'd want to go back to the Workspace page, why another additional click?

But I agree with the feedback point that you've mentioned, and that's what I was pointing out with #4487

[aman-atg]

For me, the sidebar closing is the expected behavior. Because once you've edited you'd want to go back to the Workspace page, why another additional click?

After saving the name, You might want to edit profile picture too but that won't be possible.

And We should show consistent behaviour. We're not closing Edit Profile after saving then why this one.

[parasharrajat]

Hey guys, @aman-atg @mananjadhav I think the Edit Workspace feature is just landed in the APP and internal QA is going on #4447. Thus all the issues that are coming from this will be linked to the original PR.

[MelvinBot]

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.