[HOLD for payment 2024-08-07] [$250] Switch to Expensify Classic - Field required error is shown on a field that is populated

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.4-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): dave0123seife+stest@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to account settings > Switch to Expensify Classic
2. Select a reason > Next
3. Enter any reason, click Next
4. Click on 'Switch to Expensify Classic'. Notice a new tab is opened for OD
5. Return to the ND tab and click the back button to go to the page where we put the reason
6. Click 'Next'

Expected Result:

No error is shown and proceeds to the next page

Actual Result:

This field is required' error is shown on a field that is populated

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6534140_1720191198095.ex_Switch_to_OD_issue.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014958041fe5db1abc
• Upwork Job ID: 1810162821707944573
• Last Price Increase: 2024-07-08
• Automatic offers:
• ishpaul777 | Reviewer | 103171384
• cretadn22 | Contributor | 103171385

Issue Owner

Current Issue Owner: @ishpaul777

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Switch to Expensify Classic - Field required error is shown on a field that is populated

What is the root cause of that problem?

We validate the form by checking the draftResponse

App/src/pages/settings/ExitSurvey/ExitSurveyResponsePage.tsx

Lines 112 to 114 in 1f0a462

	if (!draftResponse?.trim()) {
	errors[INPUT_IDS.RESPONSE] = translate('common.error.fieldRequired');
	}

draftResponse will always null after click Switch to Expensify Classic button on ExitSurveyConfirmPage

App/src/libs/actions/ExitSurvey.ts

Lines 41 to 67 in 1f0a462

	const finallyData: OnyxUpdate[] = [
	{
	onyxMethod: Onyx.METHOD.SET,
	key: ONYXKEYS.IS_SWITCHING_TO_OLD_DOT,
	value: false,
	},
	{
	onyxMethod: Onyx.METHOD.SET,
	key: ONYXKEYS.FORMS.EXIT_SURVEY_REASON_FORM,
	value: null,
	},
	{
	onyxMethod: Onyx.METHOD.SET,
	key: ONYXKEYS.FORMS.EXIT_SURVEY_REASON_FORM_DRAFT,
	value: null,
	},
	{
	onyxMethod: Onyx.METHOD.SET,
	key: ONYXKEYS.FORMS.EXIT_SURVEY_RESPONSE_FORM,
	value: null,
	},
	{
	onyxMethod: Onyx.METHOD.SET,
	key: ONYXKEYS.FORMS.EXIT_SURVEY_RESPONSE_FORM_DRAFT,
	value: null,
	},
	];

What changes do you think we should make in order to solve the problem?

• Solution 1
  Change the finallyData to the following to not remove the form stored value

const finallyData: OnyxUpdate[] = [
        {
            onyxMethod: Onyx.METHOD.SET,
            key: ONYXKEYS.IS_SWITCHING_TO_OLD_DOT,
            value: false,
        }
];

• Solution 2
  Add value={draftResponse} to InputWrapper on ExitSurveyResponsePage to clear the text input after click Switch to Expensify Classic button on ExitSurveyConfirmPage

<InputWrapper
      InputComponent={TextInput}
      inputID={INPUT_IDS.RESPONSE}
      label={translate(`exitSurvey.responsePlaceholder`)}
      accessibilityLabel={translate(`exitSurvey.responsePlaceholder`)}
      role={CONST.ROLE.PRESENTATION}
      autoGrowHeight
      maxAutoGrowHeight={responseInputMaxHeight}
      maxLength={CONST.MAX_COMMENT_LENGTH}
      ref={(el: AnimatedTextInputRef) => {
          if (!el) {
              return;
          }
          updateMultilineInputRange(el);
          inputCallbackRef(el);
      }}
      containerStyles={[baseResponseInputContainerStyle]}
      shouldSaveDraft
      value={draftResponse}
  />

What alternative solutions did you explore? (Optional)

[nyomanjyotisa]

Proposal updated

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Switch to Expensify Classic - Field required error is shown on a field that is populated

What is the root cause of that problem?

We are utilizing draftResponse from Onyx to validate the form

App/src/pages/settings/ExitSurvey/ExitSurveyResponsePage.tsx

Lines 112 to 114 in 1f0a462

	if (!draftResponse?.trim()) {
	errors[INPUT_IDS.RESPONSE] = translate('common.error.fieldRequired');
	}

but we reset EXIT_SURVEY_RESPONSE_FORM_DRAFT when the user clicks the "Switch to Expensify Classic" button

What changes do you think we should make in order to solve the problem?

Since we clear all data when the user clicks the "Switch to Expensify Classic" button, I recommend dismissing the RHP modal after the user clicks this button.

App/src/pages/settings/ExitSurvey/ExitSurveyConfirmPage.tsx

Line 88 in 80b0849

onPress={() => {

                     onPress={() => {
                        ExitSurvey.switchToOldDot().then(() => {
                            if (NativeModules.HybridAppModule) {
                                Navigation.resetToHome();
                                showSplashScreenOnNextStart();
                                NativeModules.HybridAppModule.closeReactNativeApp();
                            } else {
                                Link.openOldDotLink(CONST.OLDDOT_URLS.INBOX);
                            }
                            Navigation.dismissModal()
                        });
                    }}

What alternative solutions did you explore? (Optional)

It's not advisable to utilize draftResponse from Onyx for form validation

App/src/pages/settings/ExitSurvey/ExitSurveyResponsePage.tsx

Lines 110 to 114 in 80b0849

	validate={() => {
	const errors: Errors = {};
	if (!draftResponse?.trim()) {
	errors[INPUT_IDS.RESPONSE] = translate('common.error.fieldRequired');
	}

We should validate the form using its current value, similar to how we have implemented validation in other functions within our codebase

                 validate={({response}) => {
                    const errors: Errors = {};
                    if (!response.trim()) {
                        errors[INPUT_IDS.RESPONSE] = translate('common.error.fieldRequired');
                    }
                    return errors;
                }}

Then we can add value props to InputWrapper to reset the form value

Should update the same thing in ExitSurveyReasonPage Component.

[RachCHopkins]

Can confirm - I can replicate this.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014958041fe5db1abc

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)