[HOLD for payment 2024-07-17][$250] Expense - App crashes when opening an expense report after submitting another expense

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.5-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Sign in to an account
2. Go to FAB > submit expense > Manual expense
3. Enter an amount
4. Select a user you have never submitted an expense to
5. Submit the expense
6. Navigate to the chat with the user you just submitted the expense to
7. Click on the "+" icon
8. Click on submit expense > Manual expense > Enter amount >Next > Submit
9. Go to the combined expense report and open the first expense you submitted

Expected Result:

The expense report opens and the app does not crash

Actual Result:

App crashes after opening the report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6535811_1720442411664.2024-07-08_15_15_43.mp4

logs (2).txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ab200eebc7b06724
• Upwork Job ID: 1810395750787214444
• Last Price Increase: 2024-07-08
• Automatic offers:
• brunovjk | Reviewer | 103047644
• nkdengineer | Contributor | 103047648

Issue Owner

Current Issue Owner: @allroundexperts

[melvin-bot]

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@rlinoz FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Julesssss]

Crash seems to be related to Policy key changing? Are we temporarily setting it to FAKE

[rlinoz]

Taking a look at this, weird one

[rlinoz]

It looks like we are creating the first money request in a different policyID other than _FAKE_, and when we open that report again we set it back to fake, which then crashes. Looking like a backend bug.

[rlinoz]

not happening in prod though, and apparently we didn't deploy anything related to staging in Web-E

[Julesssss]

Hmm, nice. At least it points back to app.

I wonder if any of the PRs seem associated with policies. Does this issue seem related?