[HOLD for payment 2024-08-05] [$250] Task – Assignee appears in LHN only after go back online if change it offline

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4706414
Email or phone of affected tester (no customers): applausetester+jp_e_category_1@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in
3. Open any chat
4. Create a task and assign to any user
5. Open task details and go offline
6. Assign task to another user
7. Observe task details in LHN
8. Go back online

Expected Result:

Assignee appears in LHN if change it offline

Actual Result:

Assignee appears in LHN only after go back online if change it offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6537976_1720622092420.LHN_assignee_offline.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e2d6ef7ce1dc54d0
• Upwork Job ID: 1811555469876506041
• Last Price Increase: 2024-07-12
• Automatic offers:
• shubham1206agra | Reviewer | 103214635
• nkdengineer | Contributor | 103214638

Issue Owner

Current Issue Owner: @shubham1206agra

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Assignee appears in LHN only after go back online if change it offline

What is the root cause of that problem?

The format of html of task edited action doesn't match with the userMention regex /<mention-user accountID="(\d+)" *\/>/gi when we convert HTML to text so before the edit task API is complete, the assignee doesn't display in LHN

App/src/libs/ReportUtils.ts

Lines 4912 to 4915 in 7bed113

	html: `assigned to <mention-user accountID=${assigneeAccountID}></mention-user>`,
	},
	],
	person: [

What changes do you think we should make in order to solve the problem?

Update the HTML here in the same format as the data that is returned from BE

html: `assigned to <mention-user accountID="${assigneeAccountID}"/>`,

App/src/libs/ReportUtils.ts

Lines 4912 to 4915 in 7bed113

	html: `assigned to <mention-user accountID=${assigneeAccountID}></mention-user>`,
	},
	],
	person: [

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e2d6ef7ce1dc54d0

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[mallenexpensify]

Torn here. With the new assignee being greyed out, I wouldn't expect it to be accurate elsewhere. That said... there's no details in LHN, I would expect the old assignee to show. What do you think @shubham1206agra ?

[shubham1206agra]

Torn here. With the new assignee being greyed out, I wouldn't expect it to be accurate elsewhere. That said... there's no details in LHN, I would expect the old assignee to show. What do you think @shubham1206agra ?

@mallenexpensify We should show the new assignee instead here. Since optimistic action assumes the state the action would be successful. And in this case successful action would be changed assignee.