[HOLD for payment 2024-08-01] [$250] Invoice - Invoice thread opens when starting DM with the user after sending invoice to them

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Send invoice
3. Enter amount and select any receiver
4. Go to FAB > Start chat > Chat
5. Scroll down and click on the same user in Step 3 (invoice receiver)

Expected Result:

DM with the user will open

Actual Result:

Invoice thread with the user opens

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6538039_1720625521824.20240710_232325.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0165c9231ff254ae89
• Upwork Job ID: 1811427918558506425
• Last Price Increase: 2024-07-11
• Automatic offers:
• rayane-djouah | Reviewer | 103140621

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

An invoice thread opens when we select the user from new chat page.

What is the root cause of that problem?

When we select a user, it will try to find the user chat by participants using getChatByParticipants.

App/src/libs/ReportUtils.ts

Lines 5561 to 5584 in a19ef98

	function getChatByParticipants(newParticipantList: number[], reports: OnyxCollection<Report> = ReportConnection.getAllReports(), shouldIncludeGroupChats = false): OnyxEntry<Report> {
	const sortedNewParticipantList = newParticipantList.sort();
	return Object.values(reports ?? {}).find((report) => {
	const participantAccountIDs = Object.keys(report?.participants ?? {});
	// If the report has been deleted, or there are no participants (like an empty #admins room) then skip it
	if (
	participantAccountIDs.length === 0 ||
	isChatThread(report) ||
	isTaskReport(report) ||
	isMoneyRequestReport(report) ||
	isChatRoom(report) ||
	isPolicyExpenseChat(report) ||
	(isGroupChat(report) && !shouldIncludeGroupChats)
	) {
	return false;
	}
	const sortedParticipantsAccountIDs = participantAccountIDs.map(Number).sort();
	// Only return the chat if it has all the participants
	return lodashIsEqual(sortedNewParticipantList, sortedParticipantsAccountIDs);
	});
	}

The participants of the invoice report is the same as the DM participants, that is [currentUser, the other user]. Because they contains the same participant, getChatByParticipants has a chance to wrongly returns the wrong report, that is the invoice report instead of the DM.

What changes do you think we should make in order to solve the problem?

Skip invoice report/room when comparing the participant.

App/src/libs/ReportUtils.ts

Lines 5567 to 5577 in a19ef98

	if (
	participantAccountIDs.length === 0 ||
	isChatThread(report) ||
	isTaskReport(report) ||
	isMoneyRequestReport(report) ||
	isChatRoom(report) ||
	isPolicyExpenseChat(report) ||
	(isGroupChat(report) && !shouldIncludeGroupChats)
	) {
	return false;
	}

|| isInvoiceReport(report) || isInvoiceRoom(report)

(and any other report type if needed)

What alternative solutions did you explore? (Optional)

I want to propose using !isOneOnOneChat, but getChatByParticipants is also being used to find group chat in split bill.

App/src/libs/actions/IOU.ts

Lines 3806 to 3809 in a19ef98

	const allParticipantsAccountIDs = [...participantAccountIDs, currentUserAccountID];
	if (!existingSplitChatReport) {
	existingSplitChatReport = ReportUtils.getChatByParticipants(allParticipantsAccountIDs, undefined, participantAccountIDs.length > 1);
	}

So, the solution is if we aren't searching for group, then we use !isOneOnOneChat(report) condition.

|| (!shouldIncludeGroupChats && !isOneOnOneChat(report))

Then, we can remove the other checks (thread, group, task, etc.)

[trjExpensify]

@cristipaval @davidcardoza for eyes on this.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0165c9231ff254ae89

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invoice - Invoice thread opens when starting DM with the user after sending invoice to them

What is the root cause of that problem?

When we start DM with the user, we use getChatByParticipants function to find the report of the DM chat. In this function, we will exclude some types of reports and then compare the participants. But we don't exclude the invoice report and this report has the same participant with the DM chat. So sometimes this function can return wrongly if we find the invoice report first.

App/src/libs/ReportUtils.ts

Lines 5544 to 5549 in 77d95c5

	if (
	participantAccountIDs.length === 0 ||
	isChatThread(report) ||
	isTaskReport(report) ||
	isMoneyRequestReport(report) ||
	isChatRoom(report) ||

What changes do you think we should make in order to solve the problem?

To avoid this bug happening in the future, we can prioritize the one one chat and group chat. With this change, we can make sure that this function will always return the DM or group first if the participant is matched.

return lodashOrderBy(Object.values(reports ?? {}), (report) => {
    if (isOneOnOneChat(report) || (isGroupChat(report) && shouldIncludeGroupChats)) {
        return 0;
    }
    return 1;
}).find((report) => {

App/src/libs/ReportUtils.ts

Line 5540 in 77d95c5

return Object.values(reports ?? {}).find((report) => {

What alternative solutions did you explore? (Optional)