[$250] QBO UK - Menu in "Export out-of-pocket expenses as" is blank before the connection syncs

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4706870
Issue reported by: Applause - Internal Team

Action Performed:

Precondition
QBO UK connection is established in the workspace
The connection is not synced yet

1. Navigate to workspace settings > Accounting
2. Click on Export >Export out-of-pocket expenses as
3. Observe the second menu in the setting

Expected Result:

The item field in the setting is not empty and has the title of "Accounts payable"

Actual Result:

The second item which is "Accounts payable" only appears when syncing is complete and is blank before syncing

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6538186_1720633386267.2024-07-10_20_07_43.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010b2c93b291a15c58
• Upwork Job ID: 1811856308645344493
• Last Price Increase: 2024-08-08

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@abekkala FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

QBO UK - Menu in "Export out-of-pocket expenses as" is blank before the connection syncs

What is the root cause of that problem?

No fallback value is provided to title prop.

App/src/pages/workspace/accounting/qbo/export/QuickbooksOutOfPocketExpenseConfigurationPage.tsx

Line 76 in 98932a2

title={reimbursableExpensesAccount?.name}

What changes do you think we should make in order to solve the problem?

Add a fallback value or hide the MenuItem with OfflineWithFeedback when reimbursableExpensesAccount?.name is not present.

What alternative solutions did you explore? (Optional)

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Menu in "Export out-of-pocket expenses as" is blank before the connection syncs

What is the root cause of that problem?

App/src/pages/workspace/accounting/qbo/export/QuickbooksOutOfPocketExpenseConfigurationPage.tsx

Lines 76 to 77 in 3e164ed

	title={reimbursableExpensesAccount?.name}
	description={accountDescription}

Normally, when the title field is blank, the description field is shown instead (similar to "export as" in the menuItem above).

However, in this scenario, both the title and description fields are empty.

What changes do you think we should make in order to solve the problem?

Even if the title field is empty, the description field should not be left blank

we should include a default description like "account" or "bank account" if reimbursableExpensesExportDestination is undefined

App/src/pages/workspace/accounting/qbo/export/QuickbooksOutOfPocketExpenseConfigurationPage.tsx

Lines 43 to 45 in 3e164ed

	default:
	break;
	}

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010b2c93b291a15c58

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)