[HOLD for payment 2024-08-14] [$250] Pay someone - Missing paid system message for paying someone

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to DM
3. Click + > Pay
4. Enter amount and pay the user
5. Click on the expense preview

Expected Result:

There will be a paid system message for paying someone (according to PR 43742)

Actual Result:

There is no paid system message for paying someone

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6538116_1720629865877.20240711_004214.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010ff4cba2e4566fca
• Upwork Job ID: 1813273027515516872
• Last Price Increase: 2024-07-16
• Automatic offers:
• tsa321 | Contributor | 103348532

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@MitchExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[tsa321]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Missing paid system message for paying someone

What is the root cause of that problem?

Here:

App/src/libs/ReportActionsUtils.ts

Lines 388 to 390 in d739580

	function getFilteredForOneTransactionView(reportActions: ReportAction[]): ReportAction[] {
	return reportActions.filter((action) => !isSentMoneyReportAction(action));
	}

the sent money/paid IOU report actions are being filtered out and therefore won't appear in reportActionsToDisplay as shown

App/src/pages/home/report/ReportActionsView.tsx

Lines 218 to 219 in d739580

	return moneyRequestActions.length === 1 ? ReportActionsUtils.getFilteredForOneTransactionView([...actions, createdAction]) : [...actions, createdAction];
	}, [allReportActions, report, transactionThreadReport]);

Consequently, they won't be displayed.

What changes do you think we should make in order to solve the problem?

If the expected result is to display the message, one solution is to remove this filter, allowing the messages to appear as intended.

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.