[HOLD for payment][$250] Mention-Numbers are displayed when editing an email mention of a user that is not a contact

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat
3. Send a message containing "@" mentioning an existing user but is not in your contact list
4. Right-click on the message > Edit comment.
5. Observe the edit field

Expected Result:

The mentioned user's full email address is displayed in the edit box

Actual Result:

User ID number is displayed in the edit box instead of the email address

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6538648_1720680873449.2024-07-11_09_51_38.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021831462503801260039
• Upwork Job ID: 1831462503801260039
• Last Price Increase: 2024-09-04

Issue Owner

Current Issue Owner: @kadiealexander

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #vip-vsb

[Tony-MK]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Mention-Numbers are displayed when editing an email mention of a user that is not a contact

What is the root cause of that problem?

The root cause of the problem is the Parser.htmlTomakdown function needs an accountIDToName map to convert the mentioned accountIDs to the respective name.

This issue occurs in the Report.saveReportActionDraft function in the ContextMenuActions.tsx file

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Lines 243 to 245 in 28e5e45

	if (!draftMessage) {
	Report.saveReportActionDraft(reportID, reportAction, Parser.htmlToMarkdown(getActionHtml(reportAction)));
	} else {

Therefore, the Parser.htmlTomakdown function returns the raw accountID because the HTML looks like the below example.

"<mention-user accountID="17038670"/>"

It returns @17038670 instead of @Alice and saves the draft as @17038670 in the onyx.

What changes do you think we should make in order to solve the problem?

We should pass an accountIDToName object for the extras argument for the Parser.htmlTomakdown.

1. The First Solution which displays "@Alice"

We should create the accountIDToName record just before calling the Report.saveReportActionDraft function.

So, the code that will create the accountIDToName object should look similar to the one below.

const accountIDToName: Record<string, string> = {} as Record<string, string>;

if (reportAction.originalMessage?.mentionedAccountIDs) {
    reportAction.originalMessage.mentionedAccountIDs.forEach((accountID: number) => {
        accountIDToName[accountID] = ReportUtils.getDisplayNameForParticipant(accountID);
    });
}

Report.saveReportActionDraft(reportID, reportAction, Parser.htmlToMarkdown(getActionHtml(reportAction),  { accountIDToName }));

Screen.Recording.2024-07-11.at.18.47.51.mov

2. The Second Solution which displays "@Hidden"

Introduce accountIDToName by the following example code shown below.

accountIDToName: ReportUtils.getDisplayNameForParticipant as unknown as Record<string, string>

Hidden.mov

What alternative solutions did you explore? (Optional)

We could use or create a function to display "@alice" instead of "@hidden" like the second solution illustrated above for cleaner code in one line.

[nkdengineer]

Edited by proposal-police: This proposal was edited at 2024-08-07 10:06:41 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

User ID number is displayed in the edit box instead of hidden

What is the root cause of that problem?

After we mention a user that we haven't chatted with before, BE returns the personal details of this user without login. And then accountIDToNameMap of this user is fallback to accountID

App/src/libs/Parser.ts

Line 18 in 2c60fc9

accountIDToNameMap[personalDetails.accountID] = personalDetails.login ?? personalDetails.displayName ?? String(personalDetails.accountID);

What changes do you think we should make in order to solve the problem?

We should fallback as an empty string here then htmlToMarkdown function can display the user as Hidden by default here

App/src/libs/Parser.ts

Line 18 in 2c60fc9

accountIDToNameMap[personalDetails.accountID] = personalDetails.login ?? personalDetails.displayName ?? String(personalDetails.accountID);

What alternative solutions did you explore? (Optional)

Result

Screen.Recording.2024-08-07.at.17.05.04.mov

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[aimane-chnaif]

@puneetlath what do you think is the expected behavior?
As no way to get login (email), should show @displayName or @Hidden?