[HOLD for payment 2024-08-09] [$125] Hold - LHN does not highlight the currently opened expense thread after holding an expense

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

issue found when validating #44810

Version Number: 9.0.7-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Create a new workspace.
3. Go to workspace chat.
4. Submit only one expense.
5. Click on the expense preview.
6. Click on the report header.
7. Click Hol.d
8. Enter a reason and save it.
9. Close the education modal.

Expected Result:

LHN will show the currently opened report.

Actual Result:

LHN does not show the currently opened report (no highlight).
This only happens when there is only one expense.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6543322_1721086196172.20240716_071358.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a8c5c567045c8e05
• Upwork Job ID: 1816139733985028955
• Last Price Increase: 2024-07-24
• Automatic offers:
• ahmedGaber93 | Reviewer | 103273548
• dominictb | Contributor | 103273549

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN does not show the currently opened report (no highlight).
This only happens when there is only one expense.

What is the root cause of that problem?

We always pass the backTo params here and here as the transaction thread report so when we hold the expense in the combine report, we still go back to the transaction thread report which is hidden in LHN when it's a one transaction thread.

What changes do you think we should make in order to solve the problem?

We should add an extra param backTo for hold option here and use this as backTo param when we go to the hold reason page here and here

And when we add the hold option, pass the backTo param as the combine report url if the we're in the combine report. Otherwise pass it as the transaction thread report url

if (isExpenseReport && shouldShowHoldAction) {
    result.push(PromotedActions.hold({isTextHold: canHoldUnholdReportAction.canHoldRequest, reportAction: moneyRequestAction, backTo: ROUTES.REPORT_WITH_ID.getRoute(transactionThreadReportID ? report.reportID : moneyRequestAction?.childReportID ?? '-1')}));
}

App/src/pages/ReportDetailsPage.tsx

Lines 521 to 523 in 7d58aa6

	if (isExpenseReport && shouldShowHoldAction) {
	result.push(PromotedActions.hold({isTextHold: canHoldUnholdReportAction.canHoldRequest, reportAction: moneyRequestAction}));
	}

What alternative solutions did you explore? (Optional)

NA