[HOLD for payment 2024-08-14] [$250] Search - Delete modal message changes to ".. these expenses" briefly when clicking Cancel

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when validating #45143
Version Number: 9.0.7-4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Precondition:

• User has at least one unpaid expense.

1. Go to staging.new.expensify.com
2. Go to Search.
3. Click on the checkbox next to one expense (one only, important)
4. Click on the dropdown.
5. Click Delete.
6. Note that the modal message is "Are you sure that you want to delete this expense?"
7. Click Cancel.
8. Note that the modal message changes to "Are you sure that you want to delete these expenses?" quickly before it disappears.

Expected Result:

The delete modal message should be consistent and not change when clicking Cancel button.

Actual Result:

The delete modal message changes from "Are you sure that you want to delete this expense?" to "Are you sure that you want to delete these expenses?" after clicking Cancel button.

This issue only happens when one expense is selected.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6543389_1721092571591.20240716_091035.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01086f676b97015a4f
• Upwork Job ID: 1815203340945056905
• Last Price Increase: 2024-07-22
• Automatic offers:
• abdulrahuman5196 | Reviewer | 103247059

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search - Delete modal message changes to ".. these expenses" briefly when clicking Cancel

What is the root cause of that problem?

When deletign expenses we clear the selected items.

App/src/components/Search/SearchListWithHeader.tsx

Lines 69 to 77 in 7d58aa6

	const handleDeleteExpenses = () => {
	if (selectedItemsToDelete.length === 0) {
	return;
	}
	clearSelectedItems();
	setDeleteExpensesConfirmModalVisible(false);
	SearchActions.deleteMoneyRequestOnSearch(hash, selectedItemsToDelete);
	};

This changes the translation from pural to singular notation for a second. This causes the text change

What changes do you think we should make in order to solve the problem?

We will clear selected options after we have hidden the modal here

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search - Delete modal message changes to ".. these expenses" briefly when clicking Cancel

What is the root cause of that problem?

The delete options are cleared before the close animation happens.

App/src/components/Search/SearchListWithHeader.tsx

Lines 62 to 65 in 7d58aa6

	const handleOnCancelConfirmModal = () => {
	setSelectedItemsToDelete([]);
	setDeleteExpensesConfirmModalVisible(false);
	};

What changes do you think we should make in order to solve the problem?

Use interaction manager to clear delete options after animation.

    const handleOnCancelConfirmModal = () => {
        setDeleteExpensesConfirmModalVisible(false);
        InteractionManager.runAfterInteractions(() => {
            setSelectedItemsToDelete([]);
        });
    };

Do the same with handleOnSelectDeleteOption function.

App/src/components/Search/SearchListWithHeader.tsx

Lines 57 to 60 in 7d58aa6

	const handleOnSelectDeleteOption = (itemsToDelete: string[]) => {
	setSelectedItemsToDelete(itemsToDelete);
	setDeleteExpensesConfirmModalVisible(true);
	};

What alternative solutions did you explore? (Optional)

We can use setTimeout instead of InteractionManager.