[HOLD for payment 2024-07-30][$250] Deep-link - Infinite skeleton loader appears when navigating to non-existing profile

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.7-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4723441
Email or phone of affected tester (no customers): gibethlehem.@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Log in to any account
2. On the URL Navigate to https://staging.new.expensify.com/a/hello

Expected Result:

Infinite skeleton loader is not shown when navigating back form "Page not found" page

Actual Result:

Infinite skeleton loader is shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6543742_1721125977716.Screen_Recording_2024-07-16_at_1.01.55_PM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01291dca77c0c7f6cb
• Upwork Job ID: 1813499751389988808
• Last Price Increase: 2024-07-17

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[marcochavezf]

Git bisect led me to this PR which possibly introduced the bug

[marcochavezf]

DM'ed @roryabraham for a possible solution since trying to revert the offending PR brings complex conflicts. I will be back in a couple of hours

[cead22]

FWIW this doesn't seem worth blocking the app deploy to me

[roryabraham]

I'm looking at this now. It seems very similar to a bug I initially fixed here. Even though that PR wasn't perfect, the RCA remains valid.

Basically, we're trying to use navigation.setParams before the navigation stack is ready. react-navigation assumes that you're calling that in response to a user action, so it isn't working in our case. Instead, we need to pass the correct initial report ID in the initialParams for the ReportScreen from within AuthScreens.

This will be a bit tricky to get right since we'll only want to calculate the initial report once, during the first render, and only if there isn't already a reportID in the URL.

[thienlnam]

Removing blocker for this issue