[HOLD for payment 2024-07-26] [$250] Features in Workspace LHN are not in the same order as in "More Features"

[yuwenmemon]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.5-12
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): All
Logs: N/A
Expensify/Expensify Issue URL:
Issue reported by: @zsgreenwald
Slack conversation: https://expensify.slack.com/archives/C06ML6X0W9L/p1721165288016089

Action Performed:

1. Go to a workspace
2. Turn on all features in under "More features"
3. They should all appear in the LHN for the workspace
4. Observe that the order they are in does not match what's in "More features"

Expected Result:

The order of the items in the LHN should be in the same order as they are in "More features"

Actual Result:

The order of the items does not match the order in "More features"

Workaround:

Yes, this is a small polish bug.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019d9f00389c515c84
• Upwork Job ID: 1813380721244668134
• Last Price Increase: 2024-07-17

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019d9f00389c515c84

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Features in Workspace LHN are not in the same order as in "More Features"

What is the root cause of that problem?

Accounting field is placed before Report Fields

App/src/pages/workspace/WorkspaceInitialPage.tsx

Lines 287 to 305 in 39e0f95

	if (featureStates?.[CONST.POLICY.MORE_FEATURES.ARE_CONNECTIONS_ENABLED]) {
	protectedCollectPolicyMenuItems.push({
	translationKey: 'workspace.common.accounting',
	icon: Expensicons.Sync,
	action: singleExecution(waitForNavigate(() => Navigation.navigate(ROUTES.POLICY_ACCOUNTING.getRoute(policyID)))),
	// brickRoadIndicator should be set when API will be ready
	brickRoadIndicator: undefined,
	routeName: SCREENS.WORKSPACE.ACCOUNTING.ROOT,
	});
	}
	if (featureStates?.[CONST.POLICY.MORE_FEATURES.ARE_REPORT_FIELDS_ENABLED]) {
	protectedCollectPolicyMenuItems.push({
	translationKey: 'workspace.common.reportFields',
	icon: Expensicons.Pencil,
	action: singleExecution(waitForNavigate(() => Navigation.navigate(ROUTES.WORKSPACE_REPORT_FIELDS.getRoute(policyID)))),
	routeName: SCREENS.WORKSPACE.REPORT_FIELDS,
	});
	}

What changes do you think we should make in order to solve the problem?

Place Accounting field is after Report Fields.

  
 if (featureStates?.[CONST.POLICY.MORE_FEATURES.ARE_REPORT_FIELDS_ENABLED]) { 
     protectedCollectPolicyMenuItems.push({ 
         translationKey: 'workspace.common.reportFields', 
         icon: Expensicons.Pencil, 
         action: singleExecution(waitForNavigate(() => Navigation.navigate(ROUTES.WORKSPACE_REPORT_FIELDS.getRoute(policyID)))), 
         routeName: SCREENS.WORKSPACE.REPORT_FIELDS, 
     }); 
 } 

 if (featureStates?.[CONST.POLICY.MORE_FEATURES.ARE_CONNECTIONS_ENABLED]) { 
     protectedCollectPolicyMenuItems.push({ 
         translationKey: 'workspace.common.accounting', 
         icon: Expensicons.Sync, 
         action: singleExecution(waitForNavigate(() => Navigation.navigate(ROUTES.POLICY_ACCOUNTING.getRoute(policyID)))), 
         // brickRoadIndicator should be set when API will be ready 
         brickRoadIndicator: undefined, 
         routeName: SCREENS.WORKSPACE.ACCOUNTING.ROOT, 
     }); 
 } 

What alternative solutions did you explore? (Optional)

POC:

[yuwenmemon]

Thanks @Krishna2323 looks good.