[HOLD for payment 2024-08-09] [$250] Invoice - There is "Delete expense" option in the invoice paid system message

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.7-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4728016
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• User has received invoice.
• The following steps will be performed by the invoice receiver.

1. Go to staging.new.expensify.com
2. Go to invoice chat.
3. Click on the invoice preview.
4. Click on the pay button.
5. Pay the invoice.
6. Right click on the paid system message.

Expected Result:

There should be no "Delete expense" option in the invoice paid system message.

Actual Result:

There is "Delete expense" option in the invoice paid system message. The invoice cannot be deleted.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6544144_1721146172425.20240717_000621.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a731bc49d6a020e0
• Upwork Job ID: 1814354277180193004
• Last Price Increase: 2024-07-19
• Automatic offers:
• FitseTLT | Contributor | 103229523

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invoice - There is "Delete expense" option in the invoice paid system message

What is the root cause of that problem?

As the linkedReport is an invoice type canAddOrDeleteTransactions will not be executed and true will be returned here

App/src/libs/ReportUtils.ts

Lines 1632 to 1635 in 7ba66a1

	if (!isEmptyObject(linkedReport) && isMoneyRequestReport(linkedReport)) {
	return canAddOrDeleteTransactions(linkedReport);
	}
	return true;

which will make the report action to be deleteable

What changes do you think we should make in order to solve the problem?

we should disallow delete menu for all pay type IOU report actions by changing

App/src/libs/ReportUtils.ts

Lines 1624 to 1628 in 7ba66a1

	const isSplitAction = ReportActionsUtils.getOriginalMessage(reportAction)?.type === CONST.IOU.REPORT_ACTION_TYPE.SPLIT;
	if (isSplitAction) {
	return false;
	}

to

const isSplitAction = ReportActionsUtils.getOriginalMessage(reportAction)?.type === CONST.IOU.REPORT_ACTION_TYPE.SPLIT;
        const isPayAction = ReportActionsUtils.getOriginalMessage(reportAction)?.type === CONST.IOU.REPORT_ACTION_TYPE.PAY;

        if (isSplitAction || isPayAction) {
            return false;
        }

We can also include other REPORT_ACTION_TYPE if needed

We can narrow down the logic by applying it to pay actions of only invoice reports isInvoiceReport(linkedReport)

What alternative solutions did you explore? (Optional)

We can change

App/src/libs/ReportUtils.ts

Line 1635 in 7ba66a1

return true;

to

return !isInvoiceReport(linkedReport);

or

return false;

alternatively change

App/src/libs/ReportUtils.ts

Line 1632 in 7ba66a1

if (!isEmptyObject(linkedReport) && isMoneyRequestReport(linkedReport)) {

to

            if (!isEmptyObject(linkedReport) && (isMoneyRequestReport(linkedReport) || isInvoiceReport(linkedReport))) {

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is an option to delete expense on a paid system message on an invoice report.

What is the root cause of that problem?

The option to delete will show if canDeleteReportAction returns true.

App/src/libs/ReportUtils.ts

Lines 1616 to 1637 in f392cd3

	function canDeleteReportAction(reportAction: OnyxInputOrEntry<ReportAction>, reportID: string): boolean {
	const report = getReportOrDraftReport(reportID);
	const isActionOwner = reportAction?.actorAccountID === currentUserAccountID;
	const policy = allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${report?.policyID}`] ?? null;
	if (ReportActionsUtils.isMoneyRequestAction(reportAction)) {
	// For now, users cannot delete split actions
	const isSplitAction = ReportActionsUtils.getOriginalMessage(reportAction)?.type === CONST.IOU.REPORT_ACTION_TYPE.SPLIT;
	if (isSplitAction) {
	return false;
	}
	const linkedReport = isThreadFirstChat(reportAction, reportID) ? getReportOrDraftReport(report?.parentReportID) : report;
	if (isActionOwner) {
	if (!isEmptyObject(linkedReport) && isMoneyRequestReport(linkedReport)) {
	return canAddOrDeleteTransactions(linkedReport);
	}
	return true;
	}
	}

For money request action, if the money request action belongs to a money request report (IOU/expense), then it will check using canAddOrDeleteTransactions, otherwise, it will straightly returns true.

In our case, it's not either an IOU/expense report, but an invoice report, so canDeleteReportAction always returns true for the paid system message (which is also an IOU action) which shows the option to delete the message.

What changes do you think we should make in order to solve the problem?

We can simplify the condition by following the condition from the details page as shown below:

App/src/pages/ReportDetailsPage.tsx

Line 195 in f392cd3

const canDeleteRequest = isActionOwner && (ReportUtils.canAddOrDeleteTransactions(moneyRequestReport) || isSelfDMTrackExpenseReport) && !isDeletedParentAction;

App/src/libs/ReportUtils.ts

Lines 1631 to 1636 in f392cd3

	if (isActionOwner) {
	if (!isEmptyObject(linkedReport) && isMoneyRequestReport(linkedReport)) {
	return canAddOrDeleteTransactions(linkedReport);
	}
	return true;
	}

to

return isActionOwner && (canAddOrDeleteTransactions(linkedReport) || isSelfDM(linkedReport)) && !ReportActionsUtils.isDeletedAction(reportAction);

we actually don't need isDeletedAction because once we delete an aciont, we can't interact with it anymore, even while offline, but I'm gonna leave that

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a731bc49d6a020e0

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[CortneyOfstad]

@jayeshmangwani we have a couple of proposals above when you have a chance — thank you!

[jayeshmangwani]

@FitseTLT I see you are suggesting 3-4 alternate changes. Can you summarize the best condition to use to avoid displaying the 'Delete expense' option on the system message?`

we should disallow delete menu for all pay type IOU report actions by changing

We can also include other REPORT_ACTION_TYPE if needed

We can narrow down the logic by applying it to pay actions of only invoice reports isInvoiceReport(linkedReport)

We can change

I think any of the above four options will solve this bug, right? If yes, which one do you think is best to add?