[Upgrades] Enable features when a user Upgrades their workspace to access them

[garrettmknight]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: All
Reproducible in staging?: Y
Reproducible in production?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @garrettmknight
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1721318654213289?thread_ts=1721057410.589669&cid=C036QM0SLJK

Action Performed:

1. Create a workpace
2. Go to More Features
3. Click/tap on the slider for ‘Report fields’
4. Click ‘Upgrade’
5. Click ‘Got it, thanks’

Expected Result:

Report fields is enabled and in the LHN and the user is directed back to the ‘More features’ page

Actual Result:

User is redirected to Profile page and Report fields isn’t enabled.

Workaround:

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[garrettmknight]

Here are the routes that each feature we've just enabled upgrades should take after the user clicks 'Got it, thanks':

• Report fields: More features with Report fields enabled.
• NetSuite: Accounting with RHP for NetSuite setup showing /accounting/netsuite/token-input
• Sage Intacct: Accounting with RHP for Sage Intacct setup showing /accounting/sage-intacct/prerequisites
• GL codes is already good, but for posterity: The path that the user followed to access, either Categories or Tags, with the RHP open to the GL code editor /gl-code
• Payroll codes: Categories with the RHP open to the Payroll code editor /payroll-code
• Tax codes: Tax page with the RHP open to the Tax code /tax-code

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• User is redirected to Profile page and Report fields isn’t enabled.

What is the root cause of that problem?

• Currently, we do not have a logic to enable feature after user click on upgrade button:
  

  App/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx

  Lines 33 to 35 in 7ba66a1

  	const upgradeToCorporate = () => {
  	Policy.upgradeToCorporate(policy.id, feature.id);
  	};

What changes do you think we should make in order to solve the problem?

• In WorkspaceUpgradePage we should create:

    const onGotit = () => {
        if (feature.id === 'reportFields') {
            Policy.enablePolicyReportFields(policyID, true);
            return ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID);
        }  
    };

• Then pass it to:
  

  App/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx

  Line 50 in 7ba66a1

  <UpgradeConfirmation

• In UpgradeConfirmation, update:
  

  App/src/pages/workspace/upgrade/UpgradeConfirmation.tsx

  Line 34 in 68c3b7f

  onButtonPress={() => Navigation.goBack(ROUTES.WORKSPACE_PROFILE.getRoute(policyID))}

  
  to:

            onButtonPress={() => {
                const routeToNavigate = onGotit?.();
                if (routeToNavigate) {
                    Navigation.navigate(routeToNavigate);
                    return;
                }
                Navigation.goBack(ROUTES.WORKSPACE_PROFILE.getRoute(policyID));
            }}

• With other features, we just need to add logic to enable it to this function:

    const onGotit = () => {
        if (feature.id === 'reportFields') {
            Policy.enablePolicyReportFields(policyID, true);
            return ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID);
        }   
    };

What alternative solutions did you explore? (Optional)

NA