Chat - User B can not put expense on hold when it has "Duplicate" status

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.7-8
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+vd_071824@applause.expensifail.com
Issue reported by: Applause - Internal Team

Issue found when executing PR #45325

Action Performed:

Pre-requisite: as User B, create a Workspace and invite user A

1. As user A, submit 3 expenses to the Workspace with the same amount and merchant, so it appear as duplicate
2. As user B, go to the workspace chat and select one of the duplicate expenses
3. Click on the header

Expected Result:

Hold option should be available when the expense has "Duplicate" status

Actual Result:

Hold option is not shown until the user first resolve the duplicates

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6546687_1721340914151.bandicam_2024-07-18_18-05-01-469.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[jliexpensify]

Hi @pecanoro @DylanDylann - it looks like this might be related to #45325, if you could have a look?

[bernhardoj]

From #44892, if it's duplicate, we don't want to show the Unhold option. (Unhold option is previously shown for duplicate expense)

[pecanoro]

If the expense is a duplicate, it is already on HOLD so there is no point in holding it again. I think this is working as expected.