[HOLD for payment 2024-08-05] [$250] [CRITICAL][Instant Submit for Control] Show delete expense option to the submitters if the expense report is not final approved

[cristipaval]

Feature Description

Make expenses on expense reports from Control Workspaces deletable by the submitter as long as the report is not final approved. Simply said: show delete expense if the report state is less that CONST.REPORT.STATE_NUM.APPROVED

Manual Test Steps

1. Have a Control Workspace with Advanced Approval workflow
   (You can enable this from OldDot -> Settings -> Workspaces -> [Control Workspace Name] -> Members)
2. Have at least 3 members in the workspace: an employee, an approver, and the owner
3. Configure the Advanced Approval workflow so that the employee submits to the approver, who forwards to the owner, who finally approves the reports
4. The employee creates 3 money requests in the workspace chat and submits the report in NewDot
5. Verify that the employee can delete one money request in NewDot
6. The approver approves the report and forwards it to the owner, in OldDot
7. Verify that the employee can delete one more money request in NewDot
8. The owner finally approves the report
9. Verify that the employee can't delete the last money request in NewDot (the Delete expense button is hidden)

cc @garrettmknight

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e0706c3b3c02cd52
• Upwork Job ID: 1814298663353507548
• Last Price Increase: 2024-07-19

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e0706c3b3c02cd52

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot]

Triggered auto assignment to @adelekennedy (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️