[$250] Dupe detect - Confirmation page with empty data opens when opening invalid dupe confirm link

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.10-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Submit two same expenses (same distance)
4. Go to transactiont thread of any expense
5. Click Review duplicates
6. Click Keep this one
7. Proceed to confirmation page
8. Copy the link
9. Modify the report ID in the link and navigate to it
10. Click Confirm

Expected Result:

In Step 9, app should open not here RHP when navigating to dupe review confirmation page of invalid report

Actual Result:

In Step 9, app opens confirmation page with empty data when navigating to invalid dupe confirmation link
In Step 10, when clicking Confirm, not here page opens

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6547833_1721456233030.20240720_141358.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01437c46405734d3fc
• Upwork Job ID: 1815459015971079692
• Last Price Increase: 2024-07-22
• Automatic offers:
• gijoe0295 | Contributor | 103220593

[melvin-bot]

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App does not show not found page when the report ID is incorrect.

What is the root cause of that problem?

We do not handle the case of incorrect report ID or transaction in Confirmation page.

What changes do you think we should make in order to solve the problem?

Wrap the page with FullPageNotFoundView whose shouldShow condition is the existence of the transaction ID just like we did with Review page:

App/src/pages/TransactionDuplicate/Review.tsx

Line 47 in 5a2602c

<FullPageNotFoundView shouldShow={transactionID === '-1'}>

Note that the transaction ID existence only can cover the report existence. That means we could never retrieve a transaction when it is not linked to any report.

[mountiny]

cc @pecanoro @JmillsExpensify @parasharrajat

[mountiny]

The proposal seems quite straightforward, @parasharrajat should we go with it?

[mountiny]

Dupe detection is behind beta so we can remove the blocker